issue 131 try to use tiff source first#132
Merged
Conversation
Collaborator
|
Looks good. Also, could do something similar instead of HistomicsStream/histomics_stream/configure.py Lines 1064 to 1068 in d29ee69 HistomicsStream/histomics_stream/configure.py Lines 24 to 25 in d29ee69 |
Leengit
approved these changes
Oct 12, 2023
Collaborator
Leengit
left a comment
There was a problem hiding this comment.
Good as is, or do more.
Collaborator
Author
|
It's good as-is. Large-image still ends up calling openslide even when using tiff source, but I think we should still keep this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When interacting with slide metadata in configure.py, try to use tiff tile source first then fall back to openslide if that fails. The openslide tile source may be leaking.