Skip to content

issue 131 try to use tiff source first#132

Merged
cooperlab merged 1 commit intomasterfrom
issue-131---try-tiff-source-first
Oct 12, 2023
Merged

issue 131 try to use tiff source first#132
cooperlab merged 1 commit intomasterfrom
issue-131---try-tiff-source-first

Conversation

@cooperlab
Copy link
Collaborator

When interacting with slide metadata in configure.py, try to use tiff tile source first then fall back to openslide if that fails. The openslide tile source may be leaking.

@Leengit Leengit linked an issue Oct 12, 2023 that may be closed by this pull request
@Leengit
Copy link
Collaborator

Leengit commented Oct 12, 2023

Looks good. Also, could do something similar instead of

ts = (
large_image_source_tiff.open(filename)
if os.path.splitext(filename)[1] in (".tif", ".tiff", ".svs")
else large_image.open(filename)
)
. Also, we probably don't need to import at both the edited location and
import large_image
import large_image_source_tiff
.

@Leengit Leengit self-requested a review October 12, 2023 19:14
Copy link
Collaborator

@Leengit Leengit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good as is, or do more.

@cooperlab
Copy link
Collaborator Author

It's good as-is. Large-image still ends up calling openslide even when using tiff source, but I think we should still keep this.

@cooperlab cooperlab merged commit eb8032c into master Oct 12, 2023
@Leengit Leengit deleted the issue-131---try-tiff-source-first branch February 2, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use tiff source by default

2 participants