Skip to content

twitter support, stage 4 - #228

Merged
Jack-Works merged 34 commits into
masterfrom
feat/twitter4
Oct 25, 2019
Merged

twitter support, stage 4#228
Jack-Works merged 34 commits into
masterfrom
feat/twitter4

Conversation

@Misaka-0x447f

@Misaka-0x447f Misaka-0x447f commented Sep 25, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor
I T
x x taskPasteIntoBio
x x taskPasteIntoPostBox
x x taskGetPostContent
x x taskGetProfile
x x injectPostBox
x x injectPostInspector
x x resolveLastRecognizedIdentity
x x collectPeople
x x collectPosts
x decrypt test blocked/upstream
fetchPostContent
fetchPostContent (facebook)
fetchProfile
autoVerifyBio
autoVerifyPost

  • I: implemented

  • T: done basic test

  • false positive on injectPostInspector

  • twitter post detail page decoding

  • encoder/decoder API: str, decoder, throws? OR str, opts

@Misaka-0x447f Misaka-0x447f self-assigned this Sep 25, 2019
@Misaka-0x447f Misaka-0x447f mentioned this pull request Sep 29, 2019
Merged
@Jack-Works

This comment has been minimized.

Sign in to view
@Misaka-0x447f

Misaka-0x447f commented Oct 9, 2019

Copy link
Copy Markdown
Contributor Author

The false positive on injectPostInspector screenshot
image

@Misaka-0x447f Misaka-0x447f mentioned this pull request Oct 10, 2019
Closed
@Misaka-0x447f
Misaka-0x447f force-pushed the feat/twitter4 branch 4 times, most recently from ed4e991 to cd2c028 Compare October 17, 2019 05:09
@Misaka-0x447f
Misaka-0x447f marked this pull request as ready for review October 18, 2019 09:30
@SunriseFox

SunriseFox commented Oct 18, 2019 •
edited by Misaka-0x447f
Loading

Copy link
Copy Markdown
Contributor
  • post box was injected to comment area, and not be able to auto paste to it
  • auto paste post not work when post box already contains something...
    fixed f427153
  • style: move decrypted content closer to main content / add padding
    delayed to stage 5.

Jack-Works
Jack-Works reviewed Oct 19, 2019
View reviewed changes
Comment thread src/social-network-provider/twitter.com/encoding.ts
Jack-Works
Jack-Works reviewed Oct 19, 2019
View reviewed changes
Comment thread src/social-network-provider/twitter.com/utils/selector.ts
Comment thread src/social-network-provider/twitter.com/utils/fetch.ts Outdated
}

export const postContentParser = (node: HTMLElement) => {
const qsa = <T extends HTMLElement>(selectors: string) =>

@Jack-Works Jack-Works Oct 19, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better var name?

@Misaka-0x447f Misaka-0x447f Oct 22, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be okay to use simple local name in short function to reduce bytes used...

@Jack-Works Jack-Works Oct 22, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔reduce bytes used???

@neruthes neruthes Oct 23, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reduce bytes used????????????????

@yisiliu yisiliu Oct 24, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please don't ever use such confusing variables with confusing reasons.

@Misaka-0x447f Misaka-0x447f Oct 24, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Comment thread src/social-network-provider/twitter.com/ui/fetch.ts Outdated
Comment thread src/social-network-provider/twitter.com/encoding.ts
Comment thread src/social-network-provider/twitter.com/utils/fetch.ts
Comment thread src/utils/utils.ts Outdated
@Jack-Works
Jack-Works self-requested a review October 19, 2019 08:15
Jack-Works
Jack-Works requested changes Oct 19, 2019
View reviewed changes

@Jack-Works Jack-Works left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requests has drafted in above

@Misaka-0x447f
Misaka-0x447f requested review from Artoria2e5, Jack-Works and SunriseFox and removed request for Artoria2e5 and SunriseFox October 22, 2019 11:48
Jack-Works
Jack-Works requested changes Oct 22, 2019
View reviewed changes
Comment thread src/social-network-provider/twitter.com/utils/postBox.ts
Comment thread src/utils/holoflowKits.ts Outdated
Comment thread src/utils/holoflowKits.ts Outdated
Comment thread src/utils/holoflowKits.ts Outdated
Jack-Works
Jack-Works requested changes Oct 23, 2019
View reviewed changes

@Jack-Works Jack-Works left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There're still 2 problems I think 🤔

@Jack-Works
Jack-Works merged commit 0dc7a00 into master Oct 25, 2019
@Jack-Works
Jack-Works deleted the feat/twitter4 branch October 25, 2019 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yisiliu yisiliu yisiliu left review comments
@Jack-Works Jack-Works Jack-Works approved these changes
@Artoria2e5 Artoria2e5 Awaiting requested review from Artoria2e5
+2 more reviewers
@neruthes neruthes neruthes left review comments
@SunriseFox SunriseFox SunriseFox approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@Misaka-0x447f Misaka-0x447f

Labels

Network: twitter.com

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Misaka-0x447f @Jack-Works @SunriseFox @neruthes @yisiliu @Artoria2e5