feat: contract readonly method rpc - #3710
Merged
Merged
Conversation
hanszhoou
force-pushed
the
hancheng/readonly-contract-method-own-rpc
branch
from
July 21, 2021 06:06
e5919fa to
f333ddd
Compare
github-actions
Bot
added
Blocked: Has Conflict
and removed
Blocked: Has Conflict
labels
hanszhoou
force-pushed
the
hancheng/readonly-contract-method-own-rpc
branch
from
July 22, 2021 07:16
624fa06 to
81b077f
Compare
hanszhoou
force-pushed
the
hancheng/readonly-contract-method-own-rpc
branch
from
July 22, 2021 07:18
81b077f to
4c62719
Compare
hanszhoou
force-pushed
the
hancheng/readonly-contract-method-own-rpc
branch
from
July 23, 2021 08:29
436b973 to
3d47750
Compare
Contributor
Author
|
|
hanszhoou
commented
Jul 23, 2021
| const { noSwitchNetworkTip = false } = props | ||
| const expectedChainId = props.chainId | ||
| const expectedNetwork = getChainName(expectedChainId) | ||
| const expectedNetwork = expectedChainId === ChainId.BSC ? 'BSC' : getChainName(expectedChainId) |
Contributor
Author
There was a problem hiding this comment.
ming thinks 'Swtich to BSC Network' is better than ' Swtich to Binance Smart Chain Mainnet Network'
hanszhoou
force-pushed
the
hancheng/readonly-contract-method-own-rpc
branch
from
July 24, 2021 05:54
092c867 to
cb7114d
Compare
hanszhoou
commented
Jul 26, 2021
| const { value, decimals, significant, symbol, classes } = props | ||
| const formatted = formatBalance(value, decimals, significant) | ||
| if (symbol) return <Fragment>{`${formatted} ${symbol}`}</Fragment> | ||
| const ordinaryClasses = useStyles() |
Contributor
Author
There was a problem hiding this comment.
I will move useStylesExtends() to @masknet/shared in another PR.
hanszhoou
force-pushed
the
hancheng/readonly-contract-method-own-rpc
branch
from
July 26, 2021 07:49
9bea236 to
5ba1bcb
Compare
hanszhoou
force-pushed
the
hancheng/readonly-contract-method-own-rpc
branch
4 times, most recently
from
July 26, 2021 10:38
4e287d5 to
18826e3
Compare
hanszhoou
force-pushed
the
hancheng/readonly-contract-method-own-rpc
branch
from
July 27, 2021 01:42
18826e3 to
f5f4946
Compare
github-actions
Bot
added
Blocked: Has Conflict
and removed
Blocked: Has Conflict
labels
feat: claim all chain tab chore: ui style
hanszhoou
force-pushed
the
hancheng/readonly-contract-method-own-rpc
branch
from
July 27, 2021 07:35
f5f4946 to
9b4261a
Compare
Contributor
|
Checked. |
nuanyang233
approved these changes
Jul 27, 2021
yanzhihong23
approved these changes
Jul 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's only one readonly method in rp and ito: check_availability()
closes #3689
closes #3765