refactor: let SearchIcon inherit color from style context - #3735
Conversation
also remove @masknet/theme from icons' dependencies
|
I want to import an icon from The reason I want an icon in Reconsidering about the relationship between Would like to hear your opinion. @Jack-Works |
| "build": "node --es-module-specifier-resolution=node ./dist/utils/ssr.js" | ||
| }, | ||
| "dependencies": { | ||
| "@masknet/theme": "workspace:*" |
There was a problem hiding this comment.
If you remove this, please also remove it from tsconfig file.
There was a problem hiding this comment.
I don't see any reference to @masknet/theme in packages/icon/tsconfig.json. What I miss?
There was a problem hiding this comment.
Oh so that was a mistake when adding that dependency
* develop: fix: absence account (#3752) feat: use swc to replace ts-loader (#3512) Revert "feat: enable es2020 syntax (#3750)" (#3758) feat: upgrade to holoflows-kit 0.9.0 (#3756) fix: type error (#3757) feat: enable es2020 syntax (#3750) refactor: remove ancient features (#3746) refactor: enhance robustness (#3664) chore: add isValidChainId (#3749) chore: update compatibility (#3747) fix: zerion with polygon & bsc (#3738) fix: the color of text placeholder (#3740) refactor: let SearchIcon inherit color from style context (#3735) chore: the default trending data provider (#3739)
4 participants
also remove @masknet/theme from icons' dependencies