fix: hot reload for plugins - #3869
Merged
Merged
Conversation
septs
approved these changes
Aug 11, 2021
Jack-Works
enabled auto-merge (squash)
August 11, 2021 05:04
UncleBill
approved these changes
Aug 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a regression introduced in #3471 which @guanbinrui converts all
import.meta.webpackHot && import.meta.webpackHot.acceptintoimport.meta.webpackHot?.accept. I was raised concern about if HMR still works and get the answer of yes but it proved it's not the case.We can go back to
?.once we get #3750 back (that depends on webpack/webpack#12960).