chore: adapt facebook minds - #4476
Merged
Merged
Conversation
Contributor
hanszhoou
marked this pull request as ready for review
September 30, 2021 08:31
Contributor
Author
|
@DimensionDev/qa |
Jack-Works
previously approved these changes
Oct 8, 2021
guanbinrui
reviewed
Oct 8, 2021
| .concat(usePostInfoDetails.postMentionedLinks()) | ||
| .find(isGoodGhosting) | ||
| .map((v) => { | ||
| return !isFacebookLink ? v : v.replace(/\?fbclid=[\S\s]*#/, '#') |
Member
There was a problem hiding this comment.
Can we handle this in postMetadataMentionedLinks and usePostInfoDetails.postMentionedLinks?
Jack-Works
reviewed
Oct 14, 2021
| * !!! THIS SHOULD NOT BE USED TO CONSTRUCT A NEW ProfileIdentifier !!! | ||
| */ | ||
| networkIdentifier: string | ||
| name: string |
Member
There was a problem hiding this comment.
Why add this field? networkIdentifier is used to do the job.
Contributor
Author
There was a problem hiding this comment.
For UI display text.
Contributor
|
Checked. |
Jack-Works
approved these changes
Oct 15, 2021
nuanyang233
approved these changes
Oct 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #4391
closes #4426
closes #4403
closes #4402
closes #4396
closes #4405
closes #4404
closes #4397
closes #4395