Skip to content

feat: public apis profile relation - #4610

Merged
jk234ert merged 6 commits into
developfrom
feat/public-apis-profileRelation
Oct 22, 2021
Merged

feat: public apis profile relation#4610
jk234ert merged 6 commits into
developfrom
feat/public-apis-profileRelation

Conversation

@jk234ert

@jk234ert jk234ert commented Oct 18, 2021

Copy link
Copy Markdown
Contributor

closes #4596

@github-actions

github-actions Bot commented Oct 18, 2021

Copy link
Copy Markdown
Contributor

@github-actions
github-actions Bot temporarily deployed to pull request October 18, 2021 03:32 Inactive
@guanbinrui guanbinrui changed the title Feat/public apis profile relation feat: public apis profile relation Oct 18, 2021
@github-actions
github-actions Bot temporarily deployed to pull request October 18, 2021 06:26 Inactive
@jk234ert
jk234ert marked this pull request as ready for review October 18, 2021 06:39
Comment thread packages/public-api/src/web.ts Outdated
createdAt: number
/** Unix timestamp */
updatedAt: number
favor: 0 | 1

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest definition on develop-2.0 is:

export enum RelationFavor {
    COLLECTED = -1,
    UNCOLLECTED = 1,
    DEPRECATED = 0,
}

Please don't use the value 0.

@github-actions
github-actions Bot temporarily deployed to pull request October 19, 2021 03:31 Inactive
@guanbinrui
guanbinrui force-pushed the feat/public-apis-profileRelation branch from 239250e to d5cfe5b Compare October 21, 2021 08:18
@github-actions
github-actions Bot temporarily deployed to pull request October 21, 2021 08:33 Inactive
@jk234ert
jk234ert merged commit 9978066 into develop Oct 22, 2021
@jk234ert
jk234ert deleted the feat/public-apis-profileRelation branch October 22, 2021 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Demand] Public api changes for mobile 2.0

3 participants