feat: public apis profile relation - #4610
Merged
Merged
Conversation
Contributor
jk234ert
marked this pull request as ready for review
October 18, 2021 06:39
Jack-Works
requested changes
Oct 18, 2021
| createdAt: number | ||
| /** Unix timestamp */ | ||
| updatedAt: number | ||
| favor: 0 | 1 |
Member
There was a problem hiding this comment.
The latest definition on develop-2.0 is:
export enum RelationFavor {
COLLECTED = -1,
UNCOLLECTED = 1,
DEPRECATED = 0,
}Please don't use the value 0.
Closed
guanbinrui
force-pushed
the
feat/public-apis-profileRelation
branch
from
October 21, 2021 08:18
239250e to
d5cfe5b
Compare
yanzhihong23
approved these changes
Oct 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #4596