feat: add support for fantom by UncleBill · Pull Request #5036 · DimensionDev/Maskbook

UncleBill · 2021-12-02T11:28:01Z

resolves #4873

Need to confirm:

Debank: Check the asset list on the dashboard page.
coingecko & CMC: Check trending view when hover $FTM token.
Trade with SushiSwap on Fantom.
Send a transaction on Fantom and check the explorer is working.
Ensure the gas estimate dialog is working.

github-actions · 2021-12-02T11:33:55Z

🚀 Deployed on https://61c9b678fd45e04d5ef68597--compassionate-northcutt-326a3a.netlify.app

guanbinrui · 2021-12-05T16:12:38Z

@UncleBill New updates on develop branch.

guanbinrui · 2021-12-05T16:44:26Z

I've written a checklist for CELO integration. Please also confirm those items in that list for the Fantom chain.

#5052 (comment)

UncleBill · 2021-12-06T04:44:42Z

Check list based on #5052 (comment)

Check if the asset list on the dashboard page is working when you choose Fantom as the network.
- Setup Fantom for DEBANK API.
Check if the trending view is working. Try to hover a Fantom token in any tweets.
- Setup Fantom for Coingeck API.
- Setup Fantom for CMC API.

Check if the gas estimate dialog is working.
- Setup Fantom for Coingeck API.

Goto chrome-extension://jkoeaghipilijlahjplgbfiocjhldnap/dashboard.html#/wallets/transfer and check the estimated USD value is working.

Trade with the DEX on Fantom.
- Integrate a DEX for Fantom.
Send a transaction and check if the explorer links are working.

septs · 2021-12-27T04:07:41Z

                        ),
                    ],
-                    [ChainId.Mainnet, ChainId.BSC, ChainId.Matic, ChainId.Arbitrum, ChainId.xDai, ChainId.Celo],
+                    [


may be can extract as multi ChainId presets.

They are used only in this file, not very common, and extracting will decrease the flexibility. We can do it anytime when we need to.

UncleBill · 2021-12-27T13:02:49Z

@DimensionDev/qa please help to verify, thanks!

* develop: chore: formatAmountPrecision (#5256) fix: tx state transition (#5271) ci: cancel previous workflows when starting a new one (#5299) feat: add support for fantom (#5036) New translations en-US.json (Chinese Simplified) (#5341) fix: backup name (#5340) fix: guarding gas config in useTransactionCallback (#5328) chore: simplify format date (#5331)

github-actions Bot temporarily deployed to pull request December 2, 2021 11:33 Inactive

UncleBill requested a review from guanbinrui December 2, 2021 12:45

guanbinrui reviewed Dec 3, 2021

View reviewed changes

Comment thread packages/mask/src/plugins/EVM/constants.ts Outdated

guanbinrui reviewed Dec 3, 2021

View reviewed changes

Comment thread packages/mask/src/plugins/Wallet/SNSAdaptor/ConnectWalletDialog/index.tsx Outdated

github-actions Bot temporarily deployed to pull request December 4, 2021 03:00 Inactive

guanbinrui reviewed Dec 5, 2021

View reviewed changes

Comment thread packages/mask/src/plugins/Wallet/SNSAdaptor/ConnectWalletDialog/index.tsx Outdated

guanbinrui reviewed Dec 5, 2021

View reviewed changes

Comment thread packages/web3-shared/evm/types/index.ts

UncleBill force-pushed the feat/fantom branch 2 times, most recently from af6d5cd to 0642764 Compare December 6, 2021 02:31

github-actions Bot temporarily deployed to pull request December 6, 2021 02:36 Inactive

Jack-Works reviewed Dec 6, 2021

View reviewed changes

Comment thread packages/mask/src/plugins/Wallet/SNSAdaptor/ConnectWalletDialog/index.tsx

Jack-Works reviewed Dec 6, 2021

View reviewed changes

Comment thread packages/mask/src/manifest.json Outdated

github-actions Bot added the Blocked: Has Conflict label Dec 6, 2021

github-actions Bot temporarily deployed to pull request December 6, 2021 04:29 Inactive

UncleBill force-pushed the feat/fantom branch from d2448ba to b269ff8 Compare December 7, 2021 03:12

github-actions Bot removed the Blocked: Has Conflict label Dec 7, 2021

github-actions Bot temporarily deployed to pull request December 7, 2021 03:18 Inactive

github-actions Bot added the Blocked: Has Conflict label Dec 7, 2021

UncleBill force-pushed the feat/fantom branch from 635b606 to a473492 Compare December 7, 2021 16:23

UncleBill marked this pull request as draft December 7, 2021 16:23

github-actions Bot removed the Blocked: Has Conflict label Dec 7, 2021

github-actions Bot temporarily deployed to pull request December 7, 2021 16:28 Inactive

github-actions Bot added the Blocked: Has Conflict label Dec 9, 2021

UncleBill added 3 commits December 13, 2021 13:36

feat: add support for Fantom

8ed3b6a

fixup! feat: add support for Fantom

4da7954

wip: debugging

f78542d

Merge remote-tracking branch 'origin/develop' into feat/fantom

5ee86e5

This was referenced Dec 25, 2021

feat(network): add Fantom network on Mask #5290

Closed

[Bounty] Integrate FANTOM into Mask #4865

Closed

feat: add fantom network #5308

Closed

Merge remote-tracking branch 'origin/develop' into feat/fantom

2760088

github-actions Bot removed the Blocked: Has Conflict label Dec 27, 2021

UncleBill force-pushed the feat/fantom branch 2 times, most recently from 5b8df83 to f2aa962 Compare December 27, 2021 03:52

Merge remote-tracking branch 'origin/feat/fantom' into feat/fantom

3b25902

UncleBill force-pushed the feat/fantom branch from f2aa962 to 3b25902 Compare December 27, 2021 04:06

septs reviewed Dec 27, 2021

View reviewed changes

UncleBill added 2 commits December 27, 2021 15:40

fix: there is circle reference between web3-shared and shared-base

313ed09

fix: some config

fc955f0

UncleBill force-pushed the feat/fantom branch from 71f19f9 to fc955f0 Compare December 27, 2021 08:43

github-actions Bot temporarily deployed to pull request December 27, 2021 08:49 Inactive

septs changed the title ~~feat: add support for Fantom~~ feat: add support for fantom Dec 27, 2021

guanbinrui reviewed Dec 27, 2021

View reviewed changes

Comment thread packages/dashboard/src/pages/Labs/components/SwapSettingDialog.tsx Outdated

guanbinrui reviewed Dec 27, 2021

View reviewed changes

Comment thread packages/web3-constants/evm/token.json Outdated

guanbinrui previously approved these changes Dec 27, 2021

View reviewed changes

github-actions Bot temporarily deployed to pull request December 27, 2021 12:30 Inactive

fixup! fix: some config

9496801

UncleBill dismissed guanbinrui’s stale review via 9496801 December 27, 2021 12:44

UncleBill force-pushed the feat/fantom branch from 6289435 to 9496801 Compare December 27, 2021 12:44

github-actions Bot temporarily deployed to pull request December 27, 2021 12:50 Inactive

Jack-Works approved these changes Dec 28, 2021

View reviewed changes

guanbinrui approved these changes Dec 29, 2021

View reviewed changes

guanbinrui merged commit 5bba318 into develop Dec 29, 2021

guanbinrui deleted the feat/fantom branch December 29, 2021 04:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: add support for fantom - #5036

feat: add support for fantom#5036
guanbinrui merged 16 commits into
developfrom
feat/fantom

UncleBill commented Dec 2, 2021 •

edited

Loading

Uh oh!

github-actions Bot commented Dec 2, 2021 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

guanbinrui commented Dec 5, 2021

Uh oh!

guanbinrui commented Dec 5, 2021 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

UncleBill commented Dec 6, 2021 •

edited

Loading

Uh oh!

septs Dec 27, 2021 •

edited

Loading

Uh oh!

UncleBill Dec 27, 2021

Uh oh!

Uh oh!

Uh oh!

UncleBill commented Dec 27, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

UncleBill commented Dec 2, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Need to confirm:

Uh oh!

github-actions Bot commented Dec 2, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

guanbinrui commented Dec 5, 2021

Uh oh!

guanbinrui commented Dec 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

UncleBill commented Dec 6, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

septs Dec 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

UncleBill Dec 27, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

UncleBill commented Dec 27, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

UncleBill commented Dec 2, 2021 •

edited

Loading

github-actions Bot commented Dec 2, 2021 •

edited

Loading

guanbinrui commented Dec 5, 2021 •

edited

Loading

UncleBill commented Dec 6, 2021 •

edited

Loading

septs Dec 27, 2021 •

edited

Loading