refactor: add plugin type definitions - #5109
Merged
Merged
Conversation
guanbinrui
force-pushed
the
feat/plugin-profile-definition
branch
from
December 8, 2021 05:00
69376da to
c36ca86
Compare
Contributor
guanbinrui
force-pushed
the
feat/plugin-profile-definition
branch
from
December 8, 2021 05:08
c36ca86 to
dd348be
Compare
guanbinrui
force-pushed
the
feat/plugin-profile-definition
branch
2 times, most recently
from
December 8, 2021 05:45
338910d to
a48c89b
Compare
guanbinrui
force-pushed
the
feat/plugin-profile-definition
branch
from
December 8, 2021 05:59
a48c89b to
90d7dac
Compare
guanbinrui
force-pushed
the
feat/plugin-profile-definition
branch
from
December 23, 2021 07:16
90d7dac to
6042953
Compare
guanbinrui
force-pushed
the
feat/plugin-profile-definition
branch
3 times, most recently
from
December 23, 2021 07:28
9f71225 to
263c40c
Compare
guanbinrui
force-pushed
the
feat/plugin-profile-definition
branch
4 times, most recently
from
December 23, 2021 08:05
c4556d6 to
bcfb163
Compare
guanbinrui
force-pushed
the
feat/plugin-profile-definition
branch
from
December 23, 2021 08:23
bcfb163 to
3830074
Compare
guanbinrui
force-pushed
the
feat/plugin-profile-definition
branch
from
December 23, 2021 09:48
b66ccb3 to
6e94619
Compare
guanbinrui
force-pushed
the
feat/plugin-profile-definition
branch
3 times, most recently
from
December 26, 2021 15:34
7bea4ca to
69a67b6
Compare
guanbinrui
force-pushed
the
feat/plugin-profile-definition
branch
from
December 26, 2021 16:21
69a67b6 to
c4ac9c1
Compare
Jack-Works
reviewed
Dec 28, 2021
Jack-Works
reviewed
Dec 28, 2021
guanbinrui
force-pushed
the
feat/plugin-profile-definition
branch
from
December 29, 2021 12:31
269c318 to
3827fcc
Compare
guanbinrui
force-pushed
the
feat/plugin-profile-definition
branch
2 times, most recently
from
December 29, 2021 12:40
174c222 to
06bde8b
Compare
guanbinrui
force-pushed
the
feat/plugin-profile-definition
branch
from
December 29, 2021 12:55
06bde8b to
3e00219
Compare
guanbinrui
force-pushed
the
feat/plugin-profile-definition
branch
from
December 29, 2021 13:14
3e00219 to
5a34c38
Compare
guanbinrui
force-pushed
the
feat/plugin-profile-definition
branch
from
December 29, 2021 13:34
5aa4cd1 to
ee921e8
Compare
yanzhihong23
added a commit
that referenced
this pull request
Dec 31, 2021
* develop: (26 commits) fix: adjust the position of nft avatar injection for mobile (#5357) fix: nftscan content-type (#5360) chore: update ito abi (#5359) refactor: sort constant keys (#5363) feat: support uniswap v3 on polygon (#5344) fix: set button root style override (#5361) chore: replace conflict detect bot (#5362) refactor: rss3 move to web3-providers (#5347) feat: nftscan icon (#5350) fix: remove nft contract icon (#5352) fix: add default prop in mui button (#5354) feat: collectible, show get more token button when balance insufficient (#5335) fix: type error fix: type error chore: run gulp sync-languages docs(i18n): sync i18n files from Crowdin (#5351) feat: implementing asset player with media-viewer (#5257) fix: secp256k1 polyfill on mobile (#5338) fix: ITO and red packet day-to-day (#5332) refactor: add plugin type definitions (#5109) ... # Conflicts: # packages/dashboard/src/pages/Labs/constants.ts # packages/dashboard/src/pages/Labs/index.tsx # packages/mask/src/components/InjectedComponents/SearchResultBox.tsx # packages/mask/src/plugins/Polls/constants.ts # packages/mask/src/plugins/Trader/SNSAdaptor/trending/TrendingViewDeck.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactor the web3 tab to accept sub-tab registering from plugin definitions. Furthermore, the sub-tab could have resolved address names and the currently visiting identity as props. Finally, it brings any plugin that could have the ability to render a sub-tab on the Web3 tab.
Under-going Tasks
DonationsandFootprintstab to the RSS3 plugin.NFTstab to the collectible plugin.closes #