fix: capture replaced transactions by querying explorer API - #5137
Merged
Conversation
Contributor
guanbinrui
force-pushed
the
fix/watch-speed-up-tx
branch
3 times, most recently
from
December 9, 2021 17:01
cd01feb to
ee6c3f5
Compare
guanbinrui
force-pushed
the
fix/watch-speed-up-tx
branch
8 times, most recently
from
December 11, 2021 14:29
229ad1f to
5bfdb95
Compare
guanbinrui
changed the title
guanbinrui
changed the title
guanbinrui
force-pushed
the
fix/watch-speed-up-tx
branch
4 times, most recently
from
December 11, 2021 16:48
41bafc5 to
9934e68
Compare
guanbinrui
force-pushed
the
fix/watch-speed-up-tx
branch
from
December 11, 2021 17:12
9934e68 to
2abb293
Compare
guanbinrui
force-pushed
the
fix/watch-speed-up-tx
branch
from
December 11, 2021 18:52
205cb89 to
4098134
Compare
guanbinrui
marked this pull request as ready for review
December 11, 2021 18:53
Contributor
|
github-actions
Bot
added
Blocked: Has Conflict
and removed
Blocked: Has Conflict
labels
github-actions
Bot
added
Blocked: Has Conflict
and removed
Blocked: Has Conflict
labels
guanbinrui
force-pushed
the
fix/watch-speed-up-tx
branch
from
December 29, 2021 07:19
fcbd946 to
7286604
Compare
guanbinrui
force-pushed
the
fix/watch-speed-up-tx
branch
from
December 29, 2021 07:21
7286604 to
3ede8e4
Compare
guanbinrui
force-pushed
the
fix/watch-speed-up-tx
branch
from
January 11, 2022 04:27
556a90d to
cff2785
Compare
github-actions
Bot
added
Blocked: Has Conflict
and removed
Blocked: Has Conflict
labels
etouyang
added a commit
to etouyang/Maskbook
that referenced
this pull request
Jan 16, 2022
* 'develop' of github.com:etouyang/Maskbook: (30 commits) update ios tf and ios appstore docs(i18n): sync i18n files from Crowdin (DimensionDev#5449) feat: should use dev proxy server when in beta (DimensionDev#5446) fix: gun2 save failure handling (DimensionDev#5440) refactor: add openocean referrer (DimensionDev#5445) feat: integrate solana chain (DimensionDev#4777) chore: contract method description (DimensionDev#5424) fix(Flow): wrong color config (DimensionDev#5441) New translations en-US.json (Quenya) (DimensionDev#5442) feat: add <FolderTabs /> (DimensionDev#5435) fix: capture replaced transactions by querying explorer API (DimensionDev#5137) New translations en-US.json (Quenya) (DimensionDev#5439) feat: add currentPersona in plugin infra fix: lint for to locale lower case (DimensionDev#5438) feat: add new api to plugin infra fix: popups ui (DimensionDev#5382) refactor: change extract text from result to option fix: plugin color (DimensionDev#5377) chore: improve timeout (DimensionDev#5436) fix: adjust dex sort rule (DimensionDev#5434) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suppose the user uses an external wallet provider to replace a transaction. We can reach the new transaction hash by querying the explorer API. For those MaskWallet maintains transactions, we can figure them by comparing two nonces. However, accounts from external wallets cannot do this cause we don't track the nonce for those accounts.
closes #4543