fix: swap box bug - #5215
Merged
Merged
Conversation
guanbinrui
reviewed
Dec 16, 2021
Contributor
Contributor
|
Checked. |
guanbinrui
approved these changes
Dec 17, 2021
guanbinrui
pushed a commit
that referenced
this pull request
Dec 17, 2021
* fix: swap box bug * chore: reply review * fix: update chainId * fix: tokenlist and zero output amount * fix: show trade if it don't have estimate gas * fix: balance bug
yanzhihong23
added a commit
that referenced
this pull request
Dec 17, 2021
* develop: fix: add cache expiration (#5229) fix: twitter comment selector (#5233) fix: swap box bug (#5215) fix: send eth can not call provider (#5228) fix: valid address and domain when transfer erc20 with ens (#5226) fix: twitter popup selector (#5231) refactor: toHex (#5232) fix: switch network problems (#5194) docs(i18n): sync i18n files from Crowdin (#5230) fix: onInstall not triggered (#5227) fix: the remaining/total numbers (#5224) fix: debank history api (#5221)
guanbinrui
added a commit
that referenced
this pull request
Dec 17, 2021
* refactor: some patches on 2.3.0 (#5214) * fix: getPastLog erorrs * refactor: hide entrance * chore: bump version to 2.3.0 * fix: dashboard error when from assets list (#5191) * fix: twitter popup selector (#5216) * fix: debank history api (#5221) * fix: the remaining/total numbers (#5224) * fix: debank api changes * fix: twitter popup selector (#5231) * fix: valid address and domain when transfer erc20 with ens (#5226) * fix: send eth can not call provider (#5228) * fix: swap box bug (#5215) * fix: swap box bug * chore: reply review * fix: update chainId * fix: tokenlist and zero output amount * fix: show trade if it don't have estimate gas * fix: balance bug * fix: twitter comment selector (#5233) * fix: add cache expiration (#5229) * fix: add cache expiration * fix: expiration time 60s * fix(Maskbox): update mask info after purchasing (#5225) * fix: reset page tag when identifier be changed (#5236) * fix: the balance on multi-networks (#5237) Co-authored-by: guanbinrui <guanbinrui@dimension.im> * fix: read network type from wrong place (#5238) Co-authored-by: Lantt <laanfor@mask.io> Co-authored-by: Hancheng Zhou <z308114274@gmail.com> Co-authored-by: nuanyang233 <nuanyang233@gmail.com> Co-authored-by: lelenei <72531217+lelenei@users.noreply.github.com> Co-authored-by: UncleBill <billbill290@gmail.com>
|
Checked |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes MASK-446 MASK-476 MASK-475