fix: walkaround of GeckoView's JSON serialization bug by stringifying the JSON object - #5312
Merged
Conversation
Contributor
Member
yanzhihong23
added a commit
that referenced
this pull request
Dec 28, 2021
* develop: (96 commits) fix: contract address (#5336) fix: entry icon (#5222) feat: web3 provider api support page size in response (#5330) refactor: move twitter encoder/decoder to the encryption package refactor: move stego to encryption package (#5247) fix: curry same address (#5327) fix: opensea contract image (#5326) fix: currySameAddress (#5325) docs(i18n): sync i18n files from Crowdin (#5324) fix: add fallback when import erc721 in popup asset list (#5295) fix: bugfix for swap page (#5278) fix: hidden rainbow when nft avatar isn't exist (#5320) chore: upgrade deps (#5321) feat: an united nft service (#4593) feat: all i18n support hmr (#5294) (#5303) refactor: update configuration url (#5317) chore: enable semantic (#5292) refactor: improve zero address (#5313) fix: walkaround of GeckoView's JSON serialization bug by stringifying the JSON object (#5312) refator: trun on switches (#5305) ... # Conflicts: # packages/mask/src/plugins/FileService/base.ts # packages/plugin-infra/src/types.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to GeckoView's bug
This PR introduces a walkaround of stringifying the JSON before sending it to the message channel.
Tested positive on Android