Skip to content

fix: nft contract default icon #5418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guanbinrui merged 6 commits into from
Jan 29, 2022
+6 −17
Merged

fix: nft contract default icon #5418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
20e85cc
fix: nft contract default icon
lelenei Jan 7, 2022
71b61e3
fix: replace nft contract default icon
lelenei Jan 7, 2022
8dc7250
fix: use token default icon
lelenei Jan 7, 2022
64aa7fe
Merge branch 'develop' into lelenei/fix-nft-contract-default-icon
hanszhoou Jan 20, 2022
cb587c5
chore: little fix
hanszhoou Jan 20, 2022
0f24cca
fix: reply review
lelenei Jan 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cspell.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,7 @@
"metas",
"metaverse",
"millify",
"mintable",
"misoperation",
"monofont",
"monospace",
Expand Down Expand Up @@ -257,8 +258,7 @@
"xlarge",
"xlink",
"zerion",
"Zubin",
"mintable"
"Zubin"
],
"ignoreWords": [
"AICANFT",
Expand Down
13 changes: 3 additions & 10 deletions packages/mask/src/plugins/Wallet/SNSAdaptor/SelectNftContractDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { useCallback, useState, useMemo } from 'react'
import { makeStyles } from '@masknet/theme'
import { DialogContent, List, ListItem, Typography, Box, Link } from '@mui/material'
import { DialogContent, List, ListItem, Typography, Box, Link, Avatar } from '@mui/material'
import {
ChainId,
ERC721ContractDetailed,
Expand All @@ -19,7 +19,6 @@ import { EthereumAddress } from 'wallet.ts'
import { SearchInput } from '../../../extension/options-page/DashboardComponents/SearchInput'
import OpenInNewIcon from '@mui/icons-material/OpenInNew'
import Fuse from 'fuse.js'
import classNames from 'classnames'
import { unionBy } from 'lodash-unified'
import { useNFTBalance } from '../../EVM/hooks'
import type { NonFungibleTokenAPI } from '@masknet/web3-providers'
Expand Down Expand Up @@ -259,20 +258,14 @@ function ContractListItem(props: ContractListItemProps) {
return (
<div style={{ position: 'relative' }}>
<ListItem className={classes.listItem} onClick={() => onSubmit(contract.contractDetailed)}>
{contract.contractDetailed.iconURL ? (
<img className={classes.icon} src={contract.contractDetailed.iconURL} />
) : null}
<Avatar className={classes.icon} src={contract.contractDetailed.iconURL} />
<Typography className={classes.contractName}>
{contract.contractDetailed.name}{' '}
{contract.contractDetailed.symbol ? '(' + contract.contractDetailed.symbol + ')' : ''}
</Typography>
{contract.balance ? <Typography className={classes.balance}>{contract.balance}</Typography> : null}
</ListItem>
<div
className={classNames(
classes.address,
contract.contractDetailed.iconURL ? '' : classes.addressNoImage,
)}>
<div className={classes.address}>
<span onClick={() => onSubmit(contract.contractDetailed)}>{contract.contractDetailed.address}</span>
<Link
href={resolveAddressLinkOnExplorer(chainId, contract.contractDetailed.address)}
Expand Down
6 changes: 1 addition & 5 deletions packages/web3-constants/evm/debank.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,6 @@
"Celo": "celo",
"Fantom": "ftm",
"Aurora": "aurora",
"Aurora_Testnet": "",
"Avalanche": "avax",
"Boba": "boba",
"Metis": "metis",
"Optimistic": "op"
"Aurora_Testnet": ""
}
}