Skip to content

chore: wallet connecting tip - #5448

Merged
hanszhoou merged 7 commits into
developfrom
hancheng/connect-wallet-tip
Jan 21, 2022
Merged

chore: wallet connecting tip#5448
hanszhoou merged 7 commits into
developfrom
hancheng/connect-wallet-tip

Conversation

@hanszhoou

@hanszhoou hanszhoou commented Jan 14, 2022

Copy link
Copy Markdown
Contributor

Description

Closes # (NO_ISSUE)

https://mask.atlassian.net/browse/MASK-652
https://mask.atlassian.net/browse/MASK-648
https://mask.atlassian.net/browse/MASK-647
https://mask.atlassian.net/browse/MASK-641

Type of change

  • Documentation
  • Code refactoring (Restructuring existing code w/o changing its observable behavior)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (a fix or feature that would make something no longer possible to do/require old user must upgrade their Mask Network to this new version)

Previews

Checklist

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
    • I have removed all in development console.logs
    • I have removed all commented code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have read Internationalization Guide and moved text fields to the i18n JSON file.

If this PR depends on external APIs:

  • I have configured those APIs with CORS headers to let extension requests get passed.
    • chrome extension: chrome-extension://[id]
    • firefox extension: moz-extension://[id]
  • I have delegated all web requests to the background service via the internal RPC bridge.

@github-actions

github-actions Bot commented Jan 14, 2022

Copy link
Copy Markdown
Contributor

@github-actions
github-actions Bot temporarily deployed to pull request January 14, 2022 09:34 Inactive
@github-actions
github-actions Bot temporarily deployed to pull request January 14, 2022 09:41 Inactive
guanbinrui
guanbinrui previously approved these changes Jan 14, 2022
@github-actions
github-actions Bot temporarily deployed to pull request January 14, 2022 10:15 Inactive
@github-actions
github-actions Bot temporarily deployed to pull request January 17, 2022 06:22 Inactive
@github-actions
github-actions Bot temporarily deployed to pull request January 17, 2022 06:30 Inactive
guanbinrui
guanbinrui previously approved these changes Jan 17, 2022
@guanbinrui

Copy link
Copy Markdown
Member

@github-actions
github-actions Bot temporarily deployed to pull request January 17, 2022 08:35 Inactive
@orange187

Copy link
Copy Markdown

Checked

@hanszhoou
hanszhoou merged commit 3aaf854 into develop Jan 21, 2022
@hanszhoou
hanszhoou deleted the hancheng/connect-wallet-tip branch January 21, 2022 04:37
etouyang added a commit to etouyang/Maskbook that referenced this pull request Jan 24, 2022
* 'develop' of github.com:etouyang/Maskbook:
  feat: enables trusted types in develop mode (DimensionDev#5509)
  chore: replace network selected icon (DimensionDev#5497)
  docs(i18n): sync i18n files from Crowdin (DimensionDev#5504)
  fix: token balance precision and loading loop (DimensionDev#5419)
  fix: dashboard load nft (DimensionDev#5505)
  feat: asset player render from chain (DimensionDev#5392)
  feat: nft avatar should be available when nft asset is non-image (DimensionDev#5501)
  chore: several fix for ito and lucky drop (DimensionDev#5437)
  chore: wallet connecting tip (DimensionDev#5448)
  feat: rss3 nft (DimensionDev#5503)
  fix: replace gundb with kv storage (DimensionDev#5465)
  New translations en-US.json (Chinese Simplified) (DimensionDev#5500)

# Conflicts:
#	pnpm-lock.yaml
yanzhihong23 added a commit that referenced this pull request Jan 25, 2022
* develop: (89 commits)
  refactor: reduce rpc queries (#5393)
  fix: rss3 nft crash (#5515)
  fix: return type (#5506)
  Revert "feat: enables trusted types in develop mode (#5509)"
  fix: kv storage increase network identification (#5512)
  feat(avalanche): integrate avalanche network  (#5289)
  feat: optimize NFT avatar's price display rule (#5104)
  feat: optimize NFT avatar's price display rule (#5104)
  feat: enables trusted types in develop mode (#5509)
  chore: replace network selected icon (#5497)
  docs(i18n): sync i18n files from Crowdin (#5504)
  fix: token balance precision and loading loop (#5419)
  fix: dashboard load nft (#5505)
  feat: asset player render from chain (#5392)
  feat: nft avatar should be available when nft asset is non-image (#5501)
  chore: several fix for ito and lucky drop (#5437)
  chore: wallet connecting tip (#5448)
  feat: rss3 nft (#5503)
  fix: replace gundb with kv storage (#5465)
  New translations en-US.json (Chinese Simplified) (#5500)
  ...

# Conflicts:
#	packages/icons/general/index.ts
#	packages/mask/src/components/InjectedComponents/SetupGuide.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants