Skip to content

fix: no-explicit-any for plugin directory #5455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guanbinrui merged 3 commits into from
Jan 17, 2022
Merged

fix: no-explicit-any for plugin directory #5455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b9a13b5
fix: no-explicit-any for plugin directory
septs Jan 17, 2022
aab7fbb
fix: ci failed
septs Jan 17, 2022
16cfed8
fix: ci failed
septs Jan 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
<!-- cspell:disable -->
<a href="https://mask.io">
<img src="https://raw.githubusercontent.com/DimensionDev/Maskbook-Website/master/img/MB--CircleCanvas--WhiteOverBlue.svg"
width="200" height="200" title="([I:b])" alt="([I:b])">
Expand Down Expand Up @@ -26,7 +27,6 @@ For general introductions, see [Mask.io](https://mask.io).
- [Mask Network on Chrome Web Store][client-chrome]
- [Mask Network on Firefox Addon Store][client-firefox] (Works on Firefox for Android too!)


- [Mask Network for iOS][client-ios]
- (Testflight!) [Mask Network for iOS Testflight][client-ios-testflight]
- (Beta!) [Mask Network for Android][client-android]
Expand Down
10 changes: 9 additions & 1 deletion packages/.eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,5 +80,13 @@
"@typescript-eslint/prefer-string-starts-ends-with": "error",
"@typescript-eslint/restrict-plus-operands": "off",
"@typescript-eslint/restrict-template-expressions": "off"
}
},
"overrides": [
{
"files": ["./plugins/**/*"],

@septs septs Jan 17, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

packages/mask/src/plugins/**/*

history problem too more (✖ 72 problems (72 errors, 0 warnings))

#4609

"rules": {
"@typescript-eslint/no-explicit-any": "error"
}
}
]
}
2 changes: 1 addition & 1 deletion packages/plugins/FileService/src/Worker/arweave.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ export async function uploadLandingPage(metadata: LandingPageMetadata) {
}

async function makePayload(data: Uint8Array, type: string) {
const transaction = await instance.createTransaction({ data }, TOKEN as any)
const transaction = await instance.createTransaction({ data }, { ...TOKEN, e: '' })
transaction.addTag('Content-Type', type)
await sign(transaction)
return transaction
Expand Down
2 changes: 1 addition & 1 deletion packages/plugins/Solana/src/apis/shared.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ export const SPL_TOKEN_PROGRAM_ID = TOKEN_PROGRAM_ID.toBase58()

interface RpcOptions {
method: string
params?: any[]
params?: unknown[]
}

export interface RpcResponse<T> {
Expand Down
2 changes: 1 addition & 1 deletion packages/plugins/example/src/Components.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { Box } from '@mui/material'
export function HelloWorld(props: any) {
export function HelloWorld(props: unknown) {
return <h1 style={{ background: 'white', color: 'black' }}>Hello, World</h1>
}
export function GlobalComponent() {
Expand Down