feat: add artblocks plugin by SebastianLF · Pull Request #5502 · DimensionDev/Maskbook

SebastianLF · 2022-01-20T15:39:43Z

Description

Integrate Art Blocks plugin into Mask. This plugin fetch and show any ArtBlocks project's data and allow user to purchase new token from this project.

Closes #4300

Previews

Resources

Mainnet:

subgraph: https://thegraph.com/hosted-service/subgraph/artblocks/art-blocks
frontend: https://www.artblocks.io/

Ropsten:

subgraph: https://thegraph.com/hosted-service/subgraph/artblocks/art-blocks-staging
frontend: https://artist-staging.artblocks.io/

Jack-Works · 2022-01-20T19:53:23Z

@@ -0,0 +1,3 @@
+export default function ArtBlocksIcon() {
+    return <img src="https://www.artblocks.io/_next/image?url=%2Fsquig.png&w=48&q=75" alt="artblocks logo" />


What if Content Security Policy

SebastianLF · 2022-01-27T15:12:45Z

I made changes requested.

LindaMask · 2022-01-27T16:49:45Z

@SebastianLF can you reach out to me on telegram please my id is lin_dao

SebastianLF · 2022-01-28T21:38:19Z

@SebastianLF can you reach out to me on telegram please my id is lin_dao

Contacted you :)

Co-authored-by: guanbinrui <52657989+guanbinrui@users.noreply.github.com>

AinuX · 2022-02-08T07:54:15Z

@SebastianLF

iShot2022-02-08.15.26.26.mp4

Please add a "Purchasing" state while processing mint operation.
Miss the share to "XXX" function after mint operation.

3. Miss switch setting for artblocks plugin in D.Market page.

4. Please format text.

5. Please adapt dark mode.

SebastianLF · 2022-02-11T04:00:42Z

@AinuX thanks for your feedbacks. Made the changes, let me know if everything is ok now.

AinuX · 2022-02-11T12:08:47Z

@SebastianLF
https://user-images.githubusercontent.com/2582974/153588422-bcd36d44-fccb-46b0-95ba-7c14581ee44b.mp4

Tx is ongoing, but the button is not in "Purchasing" state
Switch function is not work in D.Market
It's better to view the entire NFT image without scrolling

SebastianLF · 2022-02-13T03:40:10Z

@SebastianLF https://user-images.githubusercontent.com/2582974/153588422-bcd36d44-fccb-46b0-95ba-7c14581ee44b.mp4

Tx is ongoing, but the button is not in "Purchasing" state

Switch function is not work in D.Market

It's better to view the entire NFT image without scrolling

I think there is no reason to block user from clicking and therefore mint again, is not like usual nft buy/sell nfts where concurrency is crucial. On the contrary, I think it would be better to let user be able to mint again while any other transaction is processing, it could saves time. Artblocks users often mint multiple times in a row.
Notifications and sidebar's loader are enough to notify current transactions state, I think:

Let me know what you think.
The plugin switch has an uncomprehending behavior (check video below). Sometimes it works, sometimes not... and I don't find the source problem. Any suggestions where to look at ? @guanbinrui @Jack-Works

2022-02-13-06-45-19.mp4

Modified accordingly.

Jack-Works · 2022-02-13T14:53:08Z

The plugin switch has an uncomprehending behavior (check video below). Sometimes it works, sometimes not... and I don't find the source problem. Any suggestions where to look at ? @guanbinrui @Jack-Works

cc @yanzhihong23

SebastianLF · 2022-02-15T17:33:36Z

@AinuX
2. This issue is now fixed thanks to #5660

AinuX · 2022-02-16T03:54:22Z

@SebastianLF

It's better to include original post content in shared tweets, like this

…to feature/artblocks-plugin

SebastianLF · 2022-02-16T10:32:35Z

It's better to include original post content in shared tweets, like this...

@AinuX Do you mean following the same message structure ?

AinuX · 2022-02-16T10:43:03Z

It's better to include original post content in shared tweets, like this...

@AinuX Do you mean setting custom text like: "mint your unique collectible with #mask_io @RealMaskNetwork" ?

I mean just like a quote tweet. @SebastianLF

SebastianLF · 2022-02-17T07:07:29Z

It's better to include original post content in shared tweets, like this...

@AinuX Do you mean setting custom text like: "mint your unique collectible with #mask_io @RealMaskNetwork" ?

I mean just like a quote tweet. @SebastianLF

I don't understand what you mean. Can you give an example ?

AinuX · 2022-02-17T08:46:57Z

It's better to include original post content in shared tweets, like this...

@AinuX Do you mean setting custom text like: "mint your unique collectible with #mask_io @RealMaskNetwork" ?

I mean just like a quote tweet. @SebastianLF

I don't understand what you mean. Can you give an example ?
@SebastianLF
This my original post about luckydrop,
https://twitter.com/AinuxA/status/1487423520280039428
and this is a shared tweet after I claimed the luckydrop,
https://twitter.com/AinuxA/status/1487423720071524358

SebastianLF · 2022-02-18T07:29:10Z

It's better to include original post content in shared tweets, like this...

@AinuX Do you mean setting custom text like: "mint your unique collectible with #mask_io @RealMaskNetwork" ?

I mean just like a quote tweet. @SebastianLF

I don't understand what you mean. Can you give an example ?
@SebastianLF
This my original post about luckydrop,
https://twitter.com/AinuxA/status/1487423520280039428
and this is a shared tweet after I claimed the luckydrop,
https://twitter.com/AinuxA/status/1487423720071524358

@AinuX Let's talk on telegram to clarify what you are asking me to do.

SebastianLF · 2022-02-18T10:32:32Z

@AinuX Finally! Everything should work now.

…to feature/artblocks-plugin

feat: add artblocks plugin

db967a7

gitcoinbot mentioned this pull request Jan 20, 2022

[Bounty] Integrate Art Blocks, an NFT issuance platform, into Mask Network #4300

Closed

15 tasks

Jack-Works reviewed Jan 20, 2022

View reviewed changes

SebastianLF added 4 commits January 22, 2022 10:01

Merge branch 'develop' into feature/artblocks-plugin

c66edb7

fix(artblocks): fix merge conflicts

4627587

chore(artblocks): source logo locally

b52c7c7

chore(artblocks): fix build fail

09782b9

guanbinrui reviewed Jan 24, 2022

View reviewed changes

fix(artblocks): make review changes

fe92642

SebastianLF dismissed a stale review via fe92642 January 24, 2022 22:44

guanbinrui reviewed Jan 25, 2022

View reviewed changes

Comment thread packages/mask/src/plugins/ArtBlocks/SNSAdaptor/CollectionView.tsx Outdated

guanbinrui previously approved these changes Jan 25, 2022

View reviewed changes

fix(artblocks): make review changes

c9cf41e

SebastianLF dismissed guanbinrui’s stale review via c9cf41e January 25, 2022 11:43

Jack-Works reviewed Jan 25, 2022

View reviewed changes

Comment thread packages/mask/src/plugins/ArtBlocks/SNSAdaptor/ArtBlocksIcon.tsx Outdated

fix(artblocks): make review changes

ed37a44

guanbinrui reviewed Feb 7, 2022

View reviewed changes

Comment thread packages/mask/src/plugins/ArtBlocks/SNSAdaptor/CollectionView.tsx Outdated

Update packages/mask/src/plugins/ArtBlocks/SNSAdaptor/CollectionView.tsx

364f160

Co-authored-by: guanbinrui <52657989+guanbinrui@users.noreply.github.com>

Jack-Works previously approved these changes Feb 7, 2022

View reviewed changes

guanbinrui reviewed Feb 8, 2022

View reviewed changes

Comment thread packages/mask/src/plugins/ArtBlocks/base.tsx Outdated

refactor: turn on flag

61befeb

guanbinrui dismissed Jack-Works’s stale review via 61befeb February 8, 2022 04:57

Merge branch 'develop' into feature/artblocks-plugin

5a886ec

Jack-Works previously approved these changes Feb 9, 2022

View reviewed changes

SebastianLF added 2 commits February 10, 2022 02:14

feat(artblocks): fix description format

b104f4b

fix(artblocks): fix stepper background dark mode

374cba8

SebastianLF added 3 commits February 11, 2022 21:51

fix(artblocks): display image without scrolling

24325bf

refactor(artblocks): refactor constants

71a8788

feat(artblocks): add enable suggestion feature

d933dc2

SebastianLF requested review from Jack-Works and guanbinrui February 15, 2022 20:20

Merge branch 'develop' of https://github.com/DimensionDev/Maskbook in…

0b96914

…to feature/artblocks-plugin

fix(artblocks): fix develop merge

0b411bf

SebastianLF added 2 commits February 18, 2022 13:28

fix(artblocks): fix chain boundary

c4e6fac

fix(artblocks): add current post to share message

645acea

Merge branch 'develop' of https://github.com/DimensionDev/Maskbook in…

e389e50

…to feature/artblocks-plugin

guanbinrui reviewed Feb 20, 2022

View reviewed changes

Comment thread packages/mask/src/plugins/ArtBlocks/base.tsx Outdated

refactor: update the publisher

ec915f7

guanbinrui previously approved these changes Feb 20, 2022

View reviewed changes

guanbinrui reviewed Feb 20, 2022

View reviewed changes

Comment thread packages/mask/src/plugins/ArtBlocks/base.tsx Outdated

guanbinrui dismissed their stale review via 17e90b8 February 20, 2022 09:45

refactor: update publisher

17e90b8

guanbinrui merged commit 287c323 into DimensionDev:develop Feb 20, 2022

guanbinrui mentioned this pull request Feb 22, 2022

[Release] New release 2.5.0 (minor) #5685

Merged

		@@ -0,0 +1,3 @@
		export default function ArtBlocksIcon() {
		return <img src="https://www.artblocks.io/_next/image?url=%2Fsquig.png&w=48&q=75" alt="artblocks logo" />

Uh oh!

Conversation

SebastianLF commented Jan 20, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Previews

Resources

Mainnet:

Ropsten:

Uh oh!

Jack-Works Jan 20, 2022

Choose a reason for hiding this comment

Uh oh!

SebastianLF Jan 22, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SebastianLF commented Jan 27, 2022

Uh oh!

LindaMask commented Jan 27, 2022

Uh oh!

SebastianLF commented Jan 28, 2022

Uh oh!

Uh oh!

Uh oh!

AinuX commented Feb 8, 2022

Uh oh!

SebastianLF commented Feb 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AinuX commented Feb 11, 2022

Uh oh!

SebastianLF commented Feb 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Jack-Works commented Feb 13, 2022

Uh oh!

SebastianLF commented Feb 15, 2022

Uh oh!

AinuX commented Feb 16, 2022

Uh oh!

SebastianLF commented Feb 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AinuX commented Feb 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SebastianLF commented Feb 17, 2022

Uh oh!

AinuX commented Feb 17, 2022

Uh oh!

SebastianLF commented Feb 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SebastianLF commented Feb 18, 2022

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

SebastianLF commented Jan 20, 2022 •

edited

Loading

SebastianLF commented Feb 11, 2022 •

edited

Loading

SebastianLF commented Feb 13, 2022 •

edited

Loading

SebastianLF commented Feb 16, 2022 •

edited

Loading

AinuX commented Feb 16, 2022 •

edited

Loading

SebastianLF commented Feb 18, 2022 •

edited

Loading