fix(swapbox): update native token balance correctly - #5511
Merged
Conversation
UncleBill
changed the title
UncleBill
commented
Jan 24, 2022
Contributor
nuanyang233
reviewed
Jan 24, 2022
13 tasks
guanbinrui
reviewed
Jan 25, 2022
| inputAmount: '', | ||
| inputTokenBalance: '', | ||
| outputTokenBalance: '', | ||
| inputTokenBalance: '0x0', |
UncleBill
commented
Jan 25, 2022
guanbinrui
approved these changes
Jan 25, 2022
etouyang
added a commit
to etouyang/Maskbook
that referenced
this pull request
Jan 26, 2022
* 'develop' of github.com:etouyang/Maskbook: refactor: remove unused keys (DimensionDev#5523) feat: findtruman add property critical to votes (DimensionDev#5167) chore: remove unused settings for trader (DimensionDev#5516) feat: align collection data from nftscan and opensea (DimensionDev#5507) feat: trusted types again (DimensionDev#5514) chore: replace network icon style (DimensionDev#5519) fix(solana): load nft on dashboard (DimensionDev#5520) chore: fix button color (DimensionDev#5521) feat: implement mobile db methods with rpc (DimensionDev#5461) feat: simplify create persona (DimensionDev#5468) fix(swapbox): update native token balance correctly (DimensionDev#5511) feat: temporary slippage (DimensionDev#5459) fix(aurora): add explorer config (DimensionDev#5498) feat: connect mask (DimensionDev#5353) fix: claim all && nft wall (DimensionDev#5513) refactor: reduce rpc queries (DimensionDev#5393)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During cleaning up settings for Trader, I found out that balance of native token in Swapbox page is not correct.
Also fix icon color in TraderForm