chore: dao tab id list from mask configuration by hanszhoou · Pull Request #5614 · DimensionDev/Maskbook

hanszhoou · 2022-02-07T12:06:51Z

Description

Closes # (NO_ISSUE)
https://mask.atlassian.net/browse/MASK-728
https://mask.atlassian.net/browse/MASK-725

Type of change

Documentation
Code refactoring (Restructuring existing code w/o changing its observable behavior)
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (a fix or feature that would make something no longer possible to do/require old user must upgrade their Mask Network to this new version)

Previews

Checklist

My code follows the style guidelines of this project.
I have performed a self-review of my own code.
- I have removed all in development console.logs
- I have removed all commented code.
I have commented on my code, particularly in hard-to-understand areas.
I have read Internationalization Guide and moved text fields to the i18n JSON file.

If this PR depends on external APIs:

I have configured those APIs with CORS headers to let extension requests get passed.
- chrome extension: chrome-extension://[id]
- firefox extension: moz-extension://[id]
I have delegated all web requests to the background service via the internal RPC bridge.

github-actions · 2022-02-07T12:11:08Z

🚀 Deployed on https://6215d21a867b07ae7b1dd7d4--compassionate-northcutt-326a3a.netlify.app

Jack-Works · 2022-02-08T13:52:34Z

This change set does not look good to me. The plugin-infra API should be SNS neutral. Please redesign it.

hanszhoou · 2022-02-09T02:46:22Z

@Jack-Works moved the hook to packages/mask/utils.

Jack-Works · 2022-02-09T03:36:03Z

+            shouldDisplay?: (
+                identity?: ProfileIdentity,
+                addressNames?: ProfileAddress[],
+                twitterSupportedList?: string[],


plugin infra should be SNS netural.

wenluomask · 2022-02-09T09:22:25Z

Checked.

* develop: refactor: update API naming (#5725) feat(nextid): add tip feature (#5623) feat: social-network-adaptor add opensea.io (#5703) fix: show nft avatar at twitter blue (#5723) refactor: move tokenlist and tokenprice to web3-provider (#5719) docs(i18n): sync i18n files from Crowdin (#5721) chore: upgrade dimension/kit (#5720) fix(twitter): fails to detect text color in tweet detail page (#5706) chore: change tsconfig chore: dao tab id list from mask configuration (#5614) fix(dashboard): update trading coin explicitly (#5493) feat: add web3 tab at instagram (#5657)

chore: dao id list from mask configuration

a1eacd4

hanszhoou changed the title ~~chore: dao id list from mask configuration~~ chore: dao tab id list from mask configuration Feb 7, 2022

github-actions Bot temporarily deployed to pull request February 7, 2022 12:11 Inactive

fix: cspell

3bcc6be

github-actions Bot temporarily deployed to pull request February 7, 2022 12:19 Inactive

septs reviewed Feb 7, 2022

View reviewed changes

Comment thread packages/plugin-infra/src/hooks/useDaoTabTwitterIdList.ts Outdated

hanszhoou added 3 commits February 8, 2022 18:52

fix: collectible style

6c7d7e6

Merge branch 'develop' into hancheng/configurable-dao

3958680

chore: cspell

9b1642c

github-actions Bot temporarily deployed to pull request February 8, 2022 11:02 Inactive

chore: add loaded message

d5e1dcb

github-actions Bot temporarily deployed to pull request February 9, 2022 02:42 Inactive

chore: reply code review

410796c

github-actions Bot temporarily deployed to pull request February 9, 2022 02:51 Inactive

Jack-Works requested changes Feb 9, 2022

View reviewed changes

chore: plugin infra sns netural

cf8ea4a

hanszhoou requested a review from Jack-Works February 9, 2022 08:40

github-actions Bot temporarily deployed to pull request February 9, 2022 08:45 Inactive

Jack-Works reviewed Feb 9, 2022

View reviewed changes

Comment thread packages/plugin-infra/src/types.ts Outdated

chore: reply code review

9007e43

github-actions Bot temporarily deployed to pull request February 10, 2022 14:08 Inactive

hanszhoou requested a review from Jack-Works February 11, 2022 02:35

Jack-Works reviewed Feb 11, 2022

View reviewed changes

Comment thread packages/plugins/DAO/src/SNSAdaptor/index.tsx Outdated

Jack-Works reviewed Feb 11, 2022

View reviewed changes

Comment thread packages/mask/src/utils/hooks/useDaoTabTwitterIdList.ts Outdated

chore: reply code review

5138d79

hanszhoou requested a review from Jack-Works February 11, 2022 05:46

github-actions Bot temporarily deployed to pull request February 11, 2022 05:50 Inactive

Jack-Works reviewed Feb 11, 2022

View reviewed changes

Comment thread packages/plugins/DAO/src/SNSAdaptor/index.tsx Outdated

Jack-Works reviewed Feb 11, 2022

View reviewed changes

Comment thread packages/plugins/DAO/src/SNSAdaptor/index.tsx Outdated

Update packages/plugins/DAO/src/SNSAdaptor/index.tsx

3624ac5

Jack-Works approved these changes Feb 11, 2022

View reviewed changes

github-actions Bot temporarily deployed to pull request February 11, 2022 07:22 Inactive

guanbinrui reviewed Feb 13, 2022

View reviewed changes

Comment thread packages/mask/src/utils/hooks/useDaoTabTwitterIdList.ts Outdated

Jack-Works previously approved these changes Feb 14, 2022

View reviewed changes

chore: reply code review

9aa27aa

hanszhoou dismissed Jack-Works’s stale review via 9aa27aa February 14, 2022 09:51

github-actions Bot temporarily deployed to pull request February 14, 2022 09:56 Inactive

Jack-Works previously approved these changes Feb 15, 2022

View reviewed changes

Merge branch 'develop' into hancheng/configurable-dao

2ac61ae

github-actions Bot temporarily deployed to pull request February 15, 2022 08:18 Inactive

Merge branch 'develop' into hancheng/configurable-dao

5747f21

github-actions Bot temporarily deployed to pull request February 23, 2022 05:38 Inactive

chore: use mask configuration client

d6db2b0

hanszhoou dismissed Jack-Works’s stale review via d6db2b0 February 23, 2022 06:13

github-actions Bot temporarily deployed to pull request February 23, 2022 06:20 Inactive

guanbinrui approved these changes Feb 23, 2022

View reviewed changes

guanbinrui merged commit c3f175b into develop Feb 23, 2022

guanbinrui deleted the hancheng/configurable-dao branch February 23, 2022 06:51

guanbinrui mentioned this pull request Mar 23, 2022

[Release] New release 2.6.0 (minor) #5932

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: dao tab id list from mask configuration - #5614

chore: dao tab id list from mask configuration#5614
guanbinrui merged 15 commits into
developfrom
hancheng/configurable-dao

hanszhoou commented Feb 7, 2022 •

edited

Loading

Uh oh!

github-actions Bot commented Feb 7, 2022 •

edited

Loading

Uh oh!

Uh oh!

Jack-Works commented Feb 8, 2022

Uh oh!

hanszhoou commented Feb 9, 2022

Uh oh!

Jack-Works Feb 9, 2022

Uh oh!

wenluomask commented Feb 9, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

hanszhoou commented Feb 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

Previews

Checklist

Uh oh!

github-actions Bot commented Feb 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Jack-Works commented Feb 8, 2022

Uh oh!

hanszhoou commented Feb 9, 2022

Uh oh!

Jack-Works Feb 9, 2022

Choose a reason for hiding this comment

Uh oh!

wenluomask commented Feb 9, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

hanszhoou commented Feb 7, 2022 •

edited

Loading

github-actions Bot commented Feb 7, 2022 •

edited

Loading