Skip to content

feat: facebook nft avatar - #5624

Merged
guanbinrui merged 32 commits into
developfrom
feat/facebook-nft-avatar
Feb 20, 2022
Merged

feat: facebook nft avatar#5624
guanbinrui merged 32 commits into
developfrom
feat/facebook-nft-avatar

Conversation

@nuanyang233

@nuanyang233 nuanyang233 commented Feb 8, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • feat: upload nft avatar
  • feat: avatar display

Description

CLOSE MASK-738

Show NFT avtar on Facebook

Screenshot

image

image

TODO

  • Display on mobile
  • Display on timeline
  • NFT avatar setting button

Type of change

  • Documentation
  • Code refactoring (Restructuring existing code w/o changing its observable behavior)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (a fix or feature that would make something no longer possible to do/require old user must upgrade their Mask Network to this new version)

Previews

Checklist

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
    • I have removed all in development console.logs
    • I have removed all commented code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have read Internationalization Guide and moved text fields to the i18n JSON file.

If this PR depends on external APIs:

  • I have configured those APIs with CORS headers to let extension requests get passed.
    • chrome extension: chrome-extension://[id]
    • firefox extension: moz-extension://[id]
  • I have delegated all web requests to the background service via the internal RPC bridge.

@nuanyang233
nuanyang233 marked this pull request as draft February 8, 2022 09:46
@github-actions

github-actions Bot commented Feb 8, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

🚀 Deployed on https://620f60fa088a6e1b59312e43--compassionate-northcutt-326a3a.netlify.app

@github-actions
github-actions Bot temporarily deployed to pull request February 8, 2022 09:46 Inactive
@nuanyang233
nuanyang233 force-pushed the feat/facebook-nft-avatar branch from 29239b4 to dd42006 Compare February 8, 2022 17:11
@github-actions
github-actions Bot temporarily deployed to pull request February 8, 2022 17:18 Inactive
@github-actions
github-actions Bot temporarily deployed to pull request February 9, 2022 05:08 Inactive
guanbinrui
guanbinrui reviewed Feb 9, 2022
View reviewed changes
Comment thread packages/mask/src/social-network-adaptor/twitter.com/utils/selector.ts
@github-actions
github-actions Bot temporarily deployed to pull request February 9, 2022 07:28 Inactive
@github-actions
github-actions Bot temporarily deployed to pull request February 9, 2022 07:53 Inactive
@github-actions
github-actions Bot temporarily deployed to pull request February 9, 2022 09:23 Inactive
@github-actions
github-actions Bot temporarily deployed to pull request February 10, 2022 13:37 Inactive
@github-actions
github-actions Bot temporarily deployed to pull request February 10, 2022 15:22 Inactive
@github-actions
github-actions Bot temporarily deployed to pull request February 10, 2022 16:23 Inactive
Jack-Works
Jack-Works reviewed Feb 11, 2022
View reviewed changes
Comment thread packages/mask/shared/kv-storage.ts Outdated
lelenei
lelenei previously approved these changes Feb 14, 2022
View reviewed changes
@github-actions
github-actions Bot temporarily deployed to pull request February 14, 2022 07:40 Inactive
@github-actions
github-actions Bot temporarily deployed to pull request February 17, 2022 10:57 Inactive
guanbinrui
guanbinrui previously approved these changes Feb 17, 2022
View reviewed changes
yanzhihong23
yanzhihong23 reviewed Feb 18, 2022
View reviewed changes
Comment thread packages/mask/src/components/InjectedComponents/SetupGuide.tsx
Jack-Works
Jack-Works reviewed Feb 18, 2022
View reviewed changes
Comment thread packages/mask/src/social-network-adaptor/facebook.com/collecting/identity.ts Outdated
Jack-Works
Jack-Works reviewed Feb 18, 2022
View reviewed changes
Comment thread packages/mask/src/social-network-adaptor/facebook.com/utils/selector.ts Outdated
Jack-Works
Jack-Works reviewed Feb 18, 2022
View reviewed changes
Comment thread packages/mask/src/social-network-adaptor/facebook.com/utils/selector.ts Outdated
Jack-Works
Jack-Works reviewed Feb 18, 2022
View reviewed changes
Comment thread packages/mask/src/social-network-adaptor/facebook.com/utils/avatar.ts Outdated
@github-actions
github-actions Bot temporarily deployed to pull request February 18, 2022 06:49 Inactive
@nuanyang233
nuanyang233 force-pushed the feat/facebook-nft-avatar branch from bf39a25 to ff3447e Compare February 18, 2022 06:50
@github-actions
github-actions Bot temporarily deployed to pull request February 18, 2022 06:55 Inactive
Jack-Works
Jack-Works reviewed Feb 18, 2022
View reviewed changes
Comment thread packages/mask/src/social-network-adaptor/facebook.com/utils/selector.ts Outdated
Comment thread packages/mask/src/social-network-adaptor/facebook.com/utils/selector.ts Outdated
Comment thread packages/mask/src/social-network-adaptor/facebook.com/injection/NFT/NFTAvatarEditProfile.tsx Outdated
guanbinrui
guanbinrui previously approved these changes Feb 18, 2022
View reviewed changes
@github-actions
github-actions Bot temporarily deployed to pull request February 18, 2022 09:03 Inactive
@guanbinrui
guanbinrui merged commit ce290a6 into develop Feb 20, 2022
@guanbinrui
guanbinrui deleted the feat/facebook-nft-avatar branch February 20, 2022 00:34
@guanbinrui guanbinrui mentioned this pull request Feb 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jack-Works Jack-Works Jack-Works approved these changes
@guanbinrui guanbinrui Awaiting requested review from guanbinrui
+2 more reviewers
@yanzhihong23 yanzhihong23 yanzhihong23 left review comments
@lelenei lelenei lelenei left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@nuanyang233 @wenluomask @yanzhihong23 @Jack-Works @guanbinrui @lelenei @albert-0229