Skip to content

refactor: move typed-message as a package - #5697

Merged
Jack-Works merged 22 commits into
developfrom
typed-message
Feb 24, 2022
Merged

refactor: move typed-message as a package#5697
Jack-Works merged 22 commits into
developfrom
typed-message

Conversation

@Jack-Works

@Jack-Works Jack-Works commented Feb 21, 2022

Copy link
Copy Markdown
Member

close MASK-705

@Jack-Works
Jack-Works marked this pull request as draft February 21, 2022 09:09
@github-actions

github-actions Bot commented Feb 21, 2022

Copy link
Copy Markdown
Contributor

@github-actions
github-actions Bot temporarily deployed to pull request February 21, 2022 09:15 Inactive
@github-actions
github-actions Bot temporarily deployed to pull request February 21, 2022 10:06 Inactive
@github-actions
github-actions Bot temporarily deployed to pull request February 22, 2022 06:15 Inactive
@github-actions
github-actions Bot temporarily deployed to pull request February 22, 2022 07:22 Inactive
@github-actions
github-actions Bot temporarily deployed to pull request February 22, 2022 08:27 Inactive
@github-actions
github-actions Bot temporarily deployed to pull request February 22, 2022 09:09 Inactive
@github-actions
github-actions Bot temporarily deployed to pull request February 22, 2022 10:24 Inactive
@Jack-Works
Jack-Works marked this pull request as ready for review February 22, 2022 10:41
@Jack-Works
Jack-Works requested a review from a team February 22, 2022 10:41
@github-actions
github-actions Bot temporarily deployed to pull request February 22, 2022 10:43 Inactive
@Jack-Works

Copy link
Copy Markdown
Member Author

@DimensionDev/qa

This is ready for testing.

Comment thread packages/typed-message/dom/Renderer/utils/TransformContext.ts Outdated
Comment thread packages/typed-message/dom/Renderer/utils/renderText.tsx Outdated
@github-actions
github-actions Bot temporarily deployed to pull request February 22, 2022 16:22 Inactive
@wenluomask

Copy link
Copy Markdown
Contributor

It works but the text style is weird...
Screen Shot 2022-02-23 at 11 14 05 AM

@Jack-Works

Copy link
Copy Markdown
Member Author

@wenluomask hi fixed, please try again

Comment thread packages/mask/src/components/InjectedComponents/DecryptedPostMetadataRender.tsx Outdated
@guanbinrui

Copy link
Copy Markdown
Member

Run npx gulp locale-kit --remove-unused-keys to solve CI problems.

@github-actions
github-actions Bot temporarily deployed to pull request February 23, 2022 05:51 Inactive
@wenluomask

Copy link
Copy Markdown
Contributor

Seems front size in original twitter is fixed. No matter how you change the front text, it keeps as same as encrypted context.
Screen Shot 2022-02-23 at 2 43 48 PM

@Jack-Works

Copy link
Copy Markdown
Member Author

Seems front size in original twitter is fixed. No matter how you change the front text, it keeps as same as encrypted context.

That is based on each Tweet's character count.

@wenluomask

Copy link
Copy Markdown
Contributor

Seems front size in original twitter is fixed. No matter how you change the front text, it keeps as same as encrypted context.

That is based on each Tweet's character count.

Please contact me in Rocket Chat.

@github-actions
github-actions Bot temporarily deployed to pull request February 24, 2022 05:18 Inactive
@wenluomask

Copy link
Copy Markdown
Contributor

Checked.

@Jack-Works
Jack-Works merged commit 2da774d into develop Feb 24, 2022
@Jack-Works
Jack-Works deleted the typed-message branch February 24, 2022 10:22
yanzhihong23 added a commit that referenced this pull request Feb 24, 2022
* develop:
  refactor: move typed-message as a package (#5697)
  refactor: move a file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants