Skip to content

fix: typed-message transformer order #5753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jack-Works merged 1 commit into from
Mar 4, 2022
Merged

fix: typed-message transformer order #5753

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions packages/mask/src/social-network/defaults/inject/PostReplacer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,22 +3,15 @@ import { createReactRootShadowed } from '../../../utils/shadow-root/renderInShad
import { PostInfoProvider } from '../../../components/DataSource/usePostInfo'
import { PostReplacer, PostReplacerProps } from '../../../components/InjectedComponents/PostReplacer'
import type { PostInfo } from '../../PostInfo'
import { makeStyles } from '@masknet/theme'
import type { DOMProxy } from '@dimensiondev/holoflows-kit'
import { noop } from 'lodash-unified'

export function injectPostReplacer<T extends string>(
config: injectPostReplacerConfig = {},
additionalPropsToPostReplacer: (classes: Record<T, string>) => Partial<PostReplacerProps> = () => ({}),
useCustomStyles: (props?: any) => { classes: Record<T, string> } = makeStyles()({}) as any,
) {
export function injectPostReplacer(config: injectPostReplacerConfig = {}) {
const PostReplacerDefault = memo(function PostReplacerDefault(props: {
zipPost: PostReplacerProps['zip']
unZipPost: PostReplacerProps['unzip']
}) {
const { classes } = useCustomStyles()
const additionalProps = additionalPropsToPostReplacer(classes)
return <PostReplacer {...additionalProps} zip={props.zipPost} unzip={props.unZipPost} />
return <PostReplacer zip={props.zipPost} unzip={props.unZipPost} />
})

const { zipPost, unzipPost } = config
Expand Down
2 changes: 1 addition & 1 deletion packages/typed-message/base/transformer/composed.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export function composeTransformers(): ComposedTransformers {
const transformers = new Set<readonly [Transformer, number]>()

function composed(message: TypedMessage, context: TransformationContext) {
return [...transformers].sort((a, b) => a[1] - b[1]).reduce((p, [c]) => c(p, context), message)
return [...transformers].sort((a, b) => b[1] - a[1]).reduce((p, [c]) => c(p, context), message)
}

const subscription = {
Expand Down