Skip to content

fix: typo - #5756

Merged
guanbinrui merged 6 commits into
developfrom
lelenei/mask-863
Mar 6, 2022
Merged

fix: typo#5756
guanbinrui merged 6 commits into
developfrom
lelenei/mask-863

Conversation

@lelenei

@lelenei lelenei commented Mar 2, 2022

Copy link
Copy Markdown
Contributor

Description

Closes # (NO_ISSUE)

Type of change

  • Documentation
  • Code refactoring (Restructuring existing code w/o changing its observable behavior)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (a fix or feature that would make something no longer possible to do/require old user must upgrade their Mask Network to this new version)

Previews

Checklist

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
    • I have removed all in development console.logs
    • I have removed all commented code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have read Internationalization Guide and moved text fields to the i18n JSON file.

If this PR depends on external APIs:

  • I have configured those APIs with CORS headers to let extension requests get passed.
    • chrome extension: chrome-extension://[id]
    • firefox extension: moz-extension://[id]
  • I have delegated all web requests to the background service via the internal RPC bridge.

@github-actions

github-actions Bot commented Mar 2, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

🚀 Deployed on https://6222f9fcd9b8df6604f07474--compassionate-northcutt-326a3a.netlify.app

@github-actions
github-actions Bot temporarily deployed to pull request March 2, 2022 03:22 Inactive
guanbinrui
guanbinrui reviewed Mar 2, 2022
View reviewed changes
Comment thread packages/mask/shared-ui/locales/en-US.json Outdated
@guanbinrui

guanbinrui commented Mar 2, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Checked.

No. He didn't do anything related to the issue.

@wenluomask

wenluomask commented Mar 2, 2022

Copy link
Copy Markdown
Contributor

Checked.

No. He didn't do anything related to the issue.

I thought what you mean in Jira is Gitcoin plugin. For the Donation tab, we still need to wait for confirmation.

@github-actions
github-actions Bot temporarily deployed to pull request March 3, 2022 02:59 Inactive
@wenluomask

wenluomask commented Mar 3, 2022

Copy link
Copy Markdown
Contributor

Checked.

Jack-Works
Jack-Works previously approved these changes Mar 3, 2022
View reviewed changes
guanbinrui
guanbinrui previously approved these changes Mar 4, 2022
View reviewed changes
@github-actions
github-actions Bot temporarily deployed to pull request March 5, 2022 05:49 Inactive
@guanbinrui
guanbinrui merged commit 75749de into develop Mar 6, 2022
@guanbinrui
guanbinrui deleted the lelenei/mask-863 branch March 6, 2022 13:10
guanbinrui pushed a commit that referenced this pull request Mar 6, 2022
@lelenei @guanbinrui
fix: typo (#5756)
995a669 
* fix: typo

* fix: typo

* fix: update @magic-works/i18n-codegen

* fix: reply review
@guanbinrui guanbinrui mentioned this pull request Mar 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guanbinrui guanbinrui guanbinrui approved these changes
@Jack-Works Jack-Works Jack-Works left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lelenei @guanbinrui @wenluomask @Jack-Works