Skip to content

feat(plugin): add support for zora in collectible - #5762

Merged
guanbinrui merged 1 commit into
DimensionDev:developfrom
brymut:feat/add-zora
Mar 18, 2022
Merged

feat(plugin): add support for zora in collectible#5762
guanbinrui merged 1 commit into
DimensionDev:developfrom
brymut:feat/add-zora

Conversation

@brymut

@brymut brymut commented Mar 2, 2022

Copy link
Copy Markdown
Contributor

Description

Adding support for Zora in Collectible plugin so can get information about NFTs on Zora.

Closes #4299

Type of change

  • New feature (non-breaking change which adds functionality)

Previews

Checklist

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
    • I have removed all in development console.logs
    • I have removed all commented code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have read Internationalization Guide and moved text fields to the i18n JSON file.

If this PR depends on external APIs:

  • I have configured those APIs with CORS headers to let extension requests get passed.
    • chrome extension: chrome-extension://[id]
    • firefox extension: moz-extension://[id]
  • I have delegated all web requests to the background service via the internal RPC bridge.

@brymut

brymut commented Mar 2, 2022

Copy link
Copy Markdown
Contributor Author

Hi, may I get some help about the build error:


Note that in CI environments this setting is true by default. If you still need to run install in such cases, use "pnpm install --no-frozen-lockfile"```

Comment thread packages/web3-providers/src/zora/constants.ts Outdated
Comment thread packages/web3-providers/src/zora/index.ts Outdated
Comment thread packages/web3-providers/src/zora/index.ts Outdated
@brymut
brymut force-pushed the feat/add-zora branch 4 times, most recently from 9cfc2f8 to 8d5439f Compare March 5, 2022 15:13
@brymut
brymut requested a review from guanbinrui March 5, 2022 15:13
Comment thread packages/web3-providers/src/zora/index.ts Outdated
Comment thread packages/web3-providers/src/zora/index.ts Outdated
Comment thread packages/web3-providers/src/zora/index.ts Outdated
Comment thread packages/web3-providers/src/zora/index.ts Outdated
Comment thread packages/web3-providers/src/zora/index.ts Outdated
Comment thread packages/web3-providers/src/zora/index.ts Outdated
Comment thread packages/web3-providers/src/zora/index.ts Outdated
Comment thread packages/web3-providers/src/zora/index.ts Outdated
guanbinrui
guanbinrui previously approved these changes Mar 8, 2022
@brymut

brymut commented Mar 9, 2022

Copy link
Copy Markdown
Contributor Author

@Jack-Works could you please have a look at this?

@brymut
brymut requested a review from guanbinrui March 9, 2022 11:07
@brymut

brymut commented Mar 9, 2022

Copy link
Copy Markdown
Contributor Author

@guanbinrui could you please re-approve, had to fix conflict with new dev branch changes

@brymut

brymut commented Mar 14, 2022

Copy link
Copy Markdown
Contributor Author

Hi @guanbinrui is this ready to merge?

@guanbinrui

Copy link
Copy Markdown
Member

@DimensionDev/qa

@orange187

Copy link
Copy Markdown

@brymut When Collectibles switches to Zora, no data can be obtained and an error message is displayed (Failed to load your collectible on Zora.)

@brymut

brymut commented Mar 17, 2022

Copy link
Copy Markdown
Contributor Author

@brymut When Collectibles switches to Zora, no data can be obtained and an error message is displayed (Failed to load your collectible on Zora.)

Could you please provide example link? @orange187

@brymut

brymut commented Mar 17, 2022

Copy link
Copy Markdown
Contributor Author

For example, https://twitter.com/damedoteth/status/1487966752579403776 this tweet works @orange187

Screen.Recording.2022-03-17.at.1.27.53.PM.mov

@orange187

Copy link
Copy Markdown

@brymut

brymut commented Mar 18, 2022

Copy link
Copy Markdown
Contributor Author

@brymut https://twitter.com/AkinoMush1/status/149975710155121869

2022-03-18.10.50.45.mov

@orange187 that tweet has been deleted, is there another one? image

@orange187

Copy link
Copy Markdown

@brymut Using the test connection you provided, the image does not load properly either

2022-03-18.10.58.16.mov

@orange187

Copy link
Copy Markdown

@brymut

brymut commented Mar 18, 2022

Copy link
Copy Markdown
Contributor Author

@brymut https://twitter.com/AkinoMush1/status/1499757101551218691

This is an opensea link, not Zora

@brymut

brymut commented Mar 18, 2022

Copy link
Copy Markdown
Contributor Author

@brymut Using the test connection you provided, the image does not load properly either

2022-03-18.10.58.16.mov

Error in logs of your screen recording not coming from Collectible plug-in and I can't recreate the same error.

@orange187

orange187 commented Mar 18, 2022

Copy link
Copy Markdown

@brymut But the pictures on my side can't load normally https://twitter.com/AkinoMush1/status/1504659688717447168
image

@brymut

brymut commented Mar 18, 2022

Copy link
Copy Markdown
Contributor Author

@brymut But the pictures on my side can't load normally https://twitter.com/AkinoMush1/status/1504659688717447168 image

Works for me

Screen.Recording.2022-03-18.at.6.38.07.AM.mov

Also, I've noticed that the logo on the selector is not rendered properly in your screenshots, that was an old error I had that I have already fixed, please check that you are building up to date pr-branch, that might be the problem @orange187

@orange187

Copy link
Copy Markdown

Ok, let me see

@brymut

brymut commented Mar 18, 2022

Copy link
Copy Markdown
Contributor Author

Hi @AinuX could you please have a look too

@orange187

orange187 commented Mar 18, 2022

Copy link
Copy Markdown

@brymut Switch to Zora, the bottom is not shown make an offer
image
image

@brymut

brymut commented Mar 18, 2022

Copy link
Copy Markdown
Contributor Author

@brymut Switch to Zora, the bottom is not shown make an offer

image

image

Make offer functionality only available on Opensea, Zora's api doesn't not have endpoint. Just like how Rarible doesn't have either. @orange187

@orange187

Copy link
Copy Markdown

@brymut Switch to Zora, the bottom is not shown make an offer
image
image

Make offer functionality only available on Opensea, Zora's api doesn't not have endpoint. Just like how Rarible doesn't have either. @orange187

Oh, sorry to see the requirement just now. Yes, so far only NFT display and jump like are correct

@orange187

Copy link
Copy Markdown

Checked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bounty] Integrate Zora, an NFT auction protocol, into Mask Network

4 participants