Skip to content

fix: support translate css - #5800

Merged
jk234ert merged 5 commits into
developfrom
lelenei/fix-hexogen-mobile
Mar 29, 2022
Merged

fix: support translate css#5800
jk234ert merged 5 commits into
developfrom
lelenei/fix-hexogen-mobile

Conversation

@lelenei

@lelenei lelenei commented Mar 7, 2022

Copy link
Copy Markdown
Contributor

Description

Closes # (NO_ISSUE)

Type of change

  • Documentation
  • Code refactoring (Restructuring existing code w/o changing its observable behavior)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (a fix or feature that would make something no longer possible to do/require old user must upgrade their Mask Network to this new version)

Previews

Checklist

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
    • I have removed all in development console.logs
    • I have removed all commented code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have read Internationalization Guide and moved text fields to the i18n JSON file.

If this PR depends on external APIs:

  • I have configured those APIs with CORS headers to let extension requests get passed.
    • chrome extension: chrome-extension://[id]
    • firefox extension: moz-extension://[id]
  • I have delegated all web requests to the background service via the internal RPC bridge.

@github-actions

github-actions Bot commented Mar 7, 2022

Copy link
Copy Markdown
Contributor

@github-actions
github-actions Bot temporarily deployed to pull request March 7, 2022 04:16 Inactive
guanbinrui
guanbinrui previously approved these changes Mar 7, 2022
Jack-Works
Jack-Works previously approved these changes Mar 9, 2022
@guanbinrui

Copy link
Copy Markdown
Member

@lelenei Could you please paste an issue no?

@lelenei
lelenei dismissed stale reviews from Jack-Works and guanbinrui via 530f1e2 March 24, 2022 07:05
@lelenei

lelenei commented Mar 24, 2022

Copy link
Copy Markdown
Contributor Author

no issue no

@github-actions
github-actions Bot temporarily deployed to pull request March 24, 2022 07:11 Inactive
@github-actions
github-actions Bot temporarily deployed to pull request March 24, 2022 08:21 Inactive
@github-actions
github-actions Bot temporarily deployed to pull request March 29, 2022 07:53 Inactive
@jk234ert

Copy link
Copy Markdown
Contributor

Confirmed on mobile

@jk234ert
jk234ert merged commit b52bcc4 into develop Mar 29, 2022
@jk234ert
jk234ert deleted the lelenei/fix-hexogen-mobile branch March 29, 2022 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants