feat: rewrite shadow root css - #5809
Merged
Merged
Conversation
Contributor
UncleBill
reviewed
Mar 7, 2022
| <ErrorBoundary> | ||
| <PluginsInjectionHookRender {...props} /> | ||
| </ErrorBoundary> | ||
| <span data-plugin-render=""> |
Contributor
There was a problem hiding this comment.
Is this <span/> necessary?
Don't see any css selector match [data-plugin-render] or some other usage
Member
Author
There was a problem hiding this comment.
Not necessary. This span is used to wrap all plugins because there're many plugins and it's a noise. With this span, we can fold all plugins at once.
This data-plugin-render is not used anywhere. It's for a better view in the F12 DOM view.
guanbinrui
previously approved these changes
Mar 7, 2022
Co-authored-by: UncleBill <billbill290@gmail.com>
guanbinrui
approved these changes
Mar 8, 2022
guanbinrui
added a commit
that referenced
this pull request
Mar 10, 2022
This reverts commit 4d7fbd4.
Jack-Works
added a commit
that referenced
this pull request
Mar 10, 2022
This reverts commit 8de5cdb.
Jack-Works
added a commit
that referenced
this pull request
Mar 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close MF-97