feat(network): add harmony network by developerfred · Pull Request #5835 · DimensionDev/Maskbook

developerfred · 2022-03-08T14:27:32Z

Description

add Integration Harmony One

Closes #5832

Type of change

Documentation
Code refactoring (Restructuring existing code w/o changing its observable behavior)
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (a fix or feature that would make something no longer possible to do/require old user must upgrade their Mask Network to this new version)

Previews

Contracts List

MaskBox deploy on harmony network MysteryBox#12
RedPacket Deploy on Harmony RedPacket#42
ITO Deploy on Harmony InitialTwitterOffering#39
BalanceChecker
Multicall

Assets

Token List add harmony one token list Mask-Token-Lists#15
Asset List https://github.com/DimensionDev/assets/

UncleBill

Fails at Trader(swap). Updating token.json file would resolve it.

You should test( include but not limited to):

Trader(swap)
Claim/ITO
Assets in dashboard

guanbinrui · 2022-03-23T07:44:06Z

@developerfred Any updates?

developerfred · 2022-05-06T07:31:16Z

@wenluomask the other dex's are disabled when I investigate what might be going on.

wenluomask · 2022-05-06T08:44:53Z

@wenluomask the other dex's are disabled when I investigate what might be going on.

Did you try the swap pair 1USDC -> ONE?

developerfred · 2022-05-06T12:17:12Z

Yes, working on sushiswap

wenluomask · 2022-05-07T04:26:38Z

Yes, working on sushiswap

But VenonSwap and OpenSwap were disabled?
By the way, your latest build was failed, please build again.

developerfred · 2022-05-07T05:59:35Z

Yes, working on sushiswap

But VenonSwap and OpenSwap were disabled? By the way, your latest build was failed, please build again.

I disabled it because the approve function is not working with these two specific routes, my thought is that these dexa were holding up the network implementation.

developerfred · 2022-05-07T06:00:12Z

@wenluomask I will make a new build version

…ress info on useGetTradeContext

developerfred · 2022-05-07T06:45:37Z

@wenluomask latest version:

test movie
https://youtu.be/c73L3TbTR8s

wenluomask · 2022-05-07T07:53:28Z

The estimate gas should be "<$ 0.01", currently is "~$<$ 0.01"

6 is fixed.

developerfred · 2022-05-07T11:30:00Z

@wenluomask 4. done on
cd23f69

@wenluonmask https://app.circleci.com/pipelines/github/DimensionDev/Maskbook/27050/workflows/43c4a43f-fb37-4bac-95fd-258184e9b747/jobs/56888/artifacts

UncleBill

Please fix KingDoms and leave the i18n change in another PR.

UncleBill

LGTM

wenluomask · 2022-05-08T16:43:40Z

Congrats! Issues of Harmony were all fixed and I want to thank you for you efforts.

feat(network): add harmony network

d187eb1

This was referenced Mar 8, 2022

add harmony network DimensionDev/SmartContractProjectConfig#11

Open

deploy on harmony network DimensionDev/MysteryBox#12

Closed

Deploy on Harmony DimensionDev/RedPacket#42

Closed

Deploy on Harmony DimensionDev/InitialTwitterOffering#39

Closed

guanbinrui added Plugin: EVM Type: Bounty labels Mar 9, 2022

Jack-Works previously approved these changes Mar 12, 2022

View reviewed changes

UncleBill suggested changes Mar 15, 2022

View reviewed changes

Comment thread packages/mask/src/plugins/Trader/constants/openocean.ts Outdated

Comment thread packages/web3-constants/evm/explorer.json Outdated

developerfred dismissed Jack-Works’s stale review via 22f7b94 March 15, 2022 11:49

developerfred force-pushed the harmony-network branch from 22f7b94 to 6ef7040 Compare March 15, 2022 11:59

UncleBill reviewed Mar 16, 2022

View reviewed changes

Comment thread packages/web3-constants/evm/coinmarketcap.json Outdated

Comment thread packages/web3-constants/evm/debank.json Outdated

Comment thread packages/web3-constants/evm/coingecko.json Outdated

Comment thread packages/web3-constants/evm/token.json

Jack-Works previously approved these changes Mar 16, 2022

View reviewed changes

developerfred added 2 commits March 16, 2022 19:17

Merge remote-tracking branch 'upstream/develop' into harmony-network

2794365

feat(harmony): add wrapped token address and coins apis id

79b19e4

developerfred dismissed Jack-Works’s stale review via 79b19e4 March 16, 2022 19:30

developerfred force-pushed the harmony-network branch from 6ef7040 to 79b19e4 Compare March 16, 2022 19:30

developerfred requested review from Jack-Works and UncleBill March 16, 2022 19:30

feat(harmony): add venonswap and openswap dexs

75ae33d

developerfred force-pushed the harmony-network branch from 77a8d0f to 75ae33d Compare March 16, 2022 20:31

gitcoinbot mentioned this pull request Mar 18, 2022

[Bounty] Integrate Harmony, an L2 blockchain built on Ethereum, into Mask #5832

Closed

15 tasks

developerfred added 2 commits March 21, 2022 07:01

Merge remote-tracking branch 'upstream/develop' into harmony-network

10aff0f

chore(harmony): add ito, mask-box and redpacket address

32582b9

UncleBill suggested changes Mar 22, 2022

View reviewed changes

Comment thread packages/web3-constants/evm/debank.json Outdated

guanbinrui added Type: Bounty Plugin: EVM and removed Type: Bounty Plugin: EVM labels Mar 23, 2022

guanbinrui reviewed May 7, 2022

View reviewed changes

Comment thread packages/mask/src/plugins/Trader/trader/useGetTradeContext.ts Outdated

guanbinrui reviewed May 7, 2022

View reviewed changes

Comment thread packages/mask/src/plugins/Trader/trader/useTradeContext.ts Outdated

developerfred added 2 commits May 7, 2022 07:14

Merge remote-tracking branch 'upstream/develop' into harmony-network

1feb374

chore(harmony): enable venomswap, openswap, kingdoms and sepender add…

a215005

…ress info on useGetTradeContext

developerfred requested a review from guanbinrui May 7, 2022 06:45

UncleBill reviewed May 7, 2022

View reviewed changes

Comment thread packages/mask/shared-ui/locales/en-US.json Outdated

developerfred force-pushed the harmony-network branch from 72033f4 to 0fa3173 Compare May 7, 2022 13:48

chore(harmony): fixed show gas price value on intl

62bd17d

developerfred force-pushed the harmony-network branch from 37b34cc to 62bd17d Compare May 7, 2022 13:52

Merge branch 'develop' into harmony-network

db41921

developerfred requested a review from UncleBill May 7, 2022 14:31

UncleBill reviewed May 7, 2022

View reviewed changes

Comment thread packages/mask/src/plugins/Trader/pipes.ts Outdated

Comment thread packages/mask/shared-ui/locales/en-US.json Outdated

developerfred added 2 commits May 7, 2022 16:05

chore(harmony): fixed defiKingdoms

cbb9e44

chore(harmony): change less to small

156504e

developerfred requested a review from UncleBill May 7, 2022 15:21

UncleBill approved these changes May 8, 2022

View reviewed changes

wenluomask added Test: Tested and removed Test: Failed labels May 8, 2022

guanbinrui approved these changes May 9, 2022

View reviewed changes

guanbinrui merged commit c83643d into DimensionDev:develop May 9, 2022

Uh oh!

Conversation

developerfred commented Mar 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

Previews

Contracts List

Assets

Uh oh!

UncleBill left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

guanbinrui commented Mar 23, 2022

Uh oh!

developerfred commented May 6, 2022

Uh oh!

wenluomask commented May 6, 2022

Uh oh!

developerfred commented May 6, 2022

Uh oh!

Uh oh!

Uh oh!

wenluomask commented May 7, 2022

Uh oh!

developerfred commented May 7, 2022

Uh oh!

developerfred commented May 7, 2022

Uh oh!

developerfred commented May 7, 2022

Uh oh!

wenluomask commented May 7, 2022

Uh oh!

developerfred commented May 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

UncleBill left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

UncleBill left a comment

Choose a reason for hiding this comment

Uh oh!

wenluomask commented May 8, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

developerfred commented Mar 8, 2022 •

edited

Loading

developerfred commented May 7, 2022 •

edited

Loading