Skip to content

refactor: remove unused code from trader plugin - #5838

Merged
guanbinrui merged 2 commits into
developfrom
refacotr/remove-unused-code
Mar 9, 2022
Merged

refactor: remove unused code from trader plugin#5838
guanbinrui merged 2 commits into
developfrom
refacotr/remove-unused-code

Conversation

@guanbinrui

@guanbinrui guanbinrui commented Mar 9, 2022

Copy link
Copy Markdown
Member

Description

Remove a bunch of code that is not used in the Trader plugin.

Closes # (NO_ISSUE)

Type of change

  • Documentation
  • Code refactoring (Restructuring existing code w/o changing its observable behavior)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (a fix or feature that would make something no longer possible to do/require old user must upgrade their Mask Network to this new version)

@guanbinrui
guanbinrui requested a review from nuanyang233 March 9, 2022 04:12
@github-actions

github-actions Bot commented Mar 9, 2022

Copy link
Copy Markdown
Contributor

@github-actions
github-actions Bot temporarily deployed to pull request March 9, 2022 04:17 Inactive
@nuanyang233

nuanyang233 commented Mar 9, 2022

Copy link
Copy Markdown
Contributor

Plz remove the unused locale key.

@UncleBill

Copy link
Copy Markdown
Contributor

@septs Could you help to update the gulp task locale-kit, make it fail at CI if there are unused locale keys.

@UncleBill

Copy link
Copy Markdown
Contributor

@septs Could you help to update the gulp task locale-kit, make it fail at CI if there are unused locale keys.

It would be perfect if there is a bot can provide suggestion patch in the PR.

@UncleBill UncleBill mentioned this pull request Mar 9, 2022
5 tasks
@guanbinrui

Copy link
Copy Markdown
Member Author

Plz remove the unused locale key.

Removed.

@github-actions
github-actions Bot temporarily deployed to pull request March 9, 2022 13:41 Inactive
@guanbinrui
guanbinrui merged commit 1d6a977 into develop Mar 9, 2022
@guanbinrui
guanbinrui deleted the refacotr/remove-unused-code branch March 9, 2022 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants