refactor: compose complicated string with renderString - #5872
Closed
UncleBill wants to merge 3 commits into
Closed
Conversation
Contributor
Author
|
Should be merged after #5871 |
UncleBill
marked this pull request as draft
March 14, 2022 11:06
UncleBill
force-pushed
the
feat/popup-share
branch
3 times, most recently
from
March 22, 2022 08:51
38ff96b to
2b77f50
Compare
UncleBill
force-pushed
the
fix/render-string
branch
from
March 23, 2022 07:38
dca41d5 to
e1d39a5
Compare
UncleBill
marked this pull request as ready for review
March 23, 2022 07:38
Contributor
Author
|
Might rewrite with i18n instead. |
UncleBill
force-pushed
the
fix/render-string
branch
from
March 23, 2022 07:42
e1d39a5 to
bf9d836
Compare
septs
reviewed
Mar 23, 2022
septs
reviewed
Mar 23, 2022
| : ExtraKeys<HEAD> | K | ExtraKeys<TAIL> | ||
| : never | ||
|
|
||
| export function renderString<T extends string>(template: T, data: Record<ExtraKeys<T>, string | number>) { |
Contributor
There was a problem hiding this comment.
suggest, rename the function name to renderTemplateString
Member
There was a problem hiding this comment.
What about this already existing solution _.template?
Contributor
There was a problem hiding this comment.
lodash template function use eval function
Contributor
Author
There was a problem hiding this comment.
We might rewrite with i18n instead. I18n engine itself provides template rendering. And these places miss i18n indeed.
Contributor
Contributor
Author
|
Use i18n instead. Closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.