feat: Go Plus Security plugin by Lanttcat · Pull Request #5873 · DimensionDev/Maskbook

Lanttcat · 2022-03-14T11:19:28Z

Description

Closes #MF-167

Type of change

Documentation
Code refactoring (Restructuring existing code w/o changing its observable behavior)
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (a fix or feature that would make something no longer possible to do/require old user must upgrade their Mask Network to this new version)

Previews

Checklist

My code follows the style guidelines of this project.
I have performed a self-review of my own code.
- I have removed all in development console.logs
- I have removed all commented code.
I have commented on my code, particularly in hard-to-understand areas.
I have read Internationalization Guide and moved text fields to the i18n JSON file.

If this PR depends on external APIs:

I have configured those APIs with CORS headers to let extension requests get passed.
- chrome extension: chrome-extension://[id]
- firefox extension: moz-extension://[id]
I have delegated all web requests to the background service via the internal RPC bridge.

github-actions · 2022-03-14T11:25:04Z

🚀 Deployed on https://624551803d75127c5ef80199--compassionate-northcutt-326a3a.netlify.app

orange187 · 2022-03-30T06:31:07Z

Checked

* feat: go plus security plugin setup * feat: add get supported chain for go plus lab * feat: plugin frame step 1 * feat: add risk rules * feat: search box style * feat: panel layout * feat: panel style * feat: update i18n * feat: update rules * style: improve * style: interaction design improve * feat: add default safa item card * feat: all the field is optional * feat: use go plus lab url proxy * chore: lock file * feat: improve * fix: cspell * feat: link to explorer * chore: migrate mask message * feat: configurable app board * Revert "chore: migrate mask message" This reverts commit 817e433. * chore: resolve conflict * chore: resolve conflict * feat: open from application entry * feat: dialog background * feat: update base info * feat: footer goto go plus website * fix: order by risk * style: security panel height * refactor: create token panel component * feat: use transition for token info collapse * fix: should clear state when close dialog * fix: remove debug code * fix: rename network to chain * fix: feedback * style: dialog size * refactor: convert chain's id type from string to chain id * refactor: code review feedback * fix: should can be use when not connect wallet Co-authored-by: zhouhanseng <z308114274@gmail.com> Co-authored-by: guanbinrui <52657989+guanbinrui@users.noreply.github.com>

Lanttcat marked this pull request as draft March 14, 2022 11:19

Lanttcat changed the title ~~Go+ Security plugin~~ feat: Go Plus Security plugin Mar 14, 2022

github-actions Bot temporarily deployed to pull request March 14, 2022 11:25 Inactive

github-actions Bot temporarily deployed to pull request March 14, 2022 11:41 Inactive

github-actions Bot temporarily deployed to pull request March 17, 2022 07:12 Inactive

Lanttcat force-pushed the feat/token-security-application branch from 98e6ec4 to 561d37b Compare March 17, 2022 08:21

github-actions Bot temporarily deployed to pull request March 17, 2022 08:27 Inactive

Lanttcat force-pushed the feat/token-security-application branch from 711f392 to e264c8d Compare March 21, 2022 03:48

github-actions Bot temporarily deployed to pull request March 21, 2022 09:59 Inactive

github-actions Bot temporarily deployed to pull request March 21, 2022 10:25 Inactive

Lanttcat force-pushed the feat/token-security-application branch from 3ccb468 to 1b0a008 Compare March 24, 2022 14:42

github-actions Bot temporarily deployed to pull request March 24, 2022 14:47 Inactive

github-actions Bot temporarily deployed to pull request March 25, 2022 09:38 Inactive

github-actions Bot temporarily deployed to pull request March 25, 2022 09:46 Inactive

github-actions Bot temporarily deployed to pull request March 25, 2022 10:44 Inactive

github-actions Bot temporarily deployed to pull request March 28, 2022 03:41 Inactive

Lanttcat force-pushed the feat/token-security-application branch from ff61f4d to fdf16df Compare March 28, 2022 09:00

github-actions Bot temporarily deployed to pull request March 28, 2022 09:05 Inactive

Jack-Works reviewed Mar 29, 2022

View reviewed changes

Comment thread packages/mask/shared/index.ts Outdated

Lanttcat added 9 commits March 30, 2022 17:45

feat: go plus security plugin setup

b443e3e

feat: add get supported chain for go plus lab

e750608

feat: plugin frame step 1

98b4833

feat: add risk rules

f2d07d0

feat: search box style

fc8ace7

feat: panel layout

5791f68

feat: panel style

4d00a18

feat: update i18n

97f3384

feat: update rules

86db012

Lanttcat added 5 commits March 30, 2022 17:48

refactor: create token panel component

0fce29c

feat: use transition for token info collapse

6b8e115

fix: should clear state when close dialog

8771a42

fix: remove debug code

ffae6ba

fix: rename network to chain

c712d59

Lanttcat force-pushed the feat/token-security-application branch from e6afa87 to c712d59 Compare March 30, 2022 09:49

fix: feedback

f8e438e

github-actions Bot temporarily deployed to pull request March 30, 2022 10:42 Inactive

style: dialog size

c39fdbe

Lanttcat marked this pull request as ready for review March 30, 2022 11:04

github-actions Bot temporarily deployed to pull request March 30, 2022 11:08 Inactive

guanbinrui reviewed Mar 31, 2022

View reviewed changes

Comment thread packages/plugins/GoPlusSecurity/src/SNSAdaptor/CheckSecurityDialog.tsx Outdated

guanbinrui reviewed Mar 31, 2022

View reviewed changes

Comment thread packages/plugins/GoPlusSecurity/src/SNSAdaptor/components/SearchBox.tsx Outdated

Lanttcat added 2 commits March 31, 2022 11:48

refactor: convert chain's id type from string to chain id

6ca4e68

refactor: code review feedback

ec95436

guanbinrui previously approved these changes Mar 31, 2022

View reviewed changes

guanbinrui added the Test: Tested label Mar 31, 2022

github-actions Bot temporarily deployed to pull request March 31, 2022 03:58 Inactive

Merge branch 'develop' into feat/token-security-application

af0e7d9

guanbinrui dismissed their stale review via af0e7d9 March 31, 2022 06:43

github-actions Bot temporarily deployed to pull request March 31, 2022 06:47 Inactive

fix: should can be use when not connect wallet

c5fd1ba

github-actions Bot temporarily deployed to pull request March 31, 2022 07:00 Inactive

guanbinrui merged commit c250fe6 into develop Mar 31, 2022

guanbinrui deleted the feat/token-security-application branch March 31, 2022 07:16

guanbinrui mentioned this pull request Mar 31, 2022

[Release] Hotfix 2.6.0 => 2.6.1 (patch) #5973

Merged

guanbinrui mentioned this pull request Apr 24, 2022

[Release] New release 2.7.0 (minor) #6142

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: Go Plus Security plugin - #5873

feat: Go Plus Security plugin#5873
guanbinrui merged 40 commits into
developfrom
feat/token-security-application

Lanttcat commented Mar 14, 2022 •

edited

Loading

Uh oh!

github-actions Bot commented Mar 14, 2022 •

edited

Loading

Uh oh!

Uh oh!

orange187 commented Mar 30, 2022

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

Lanttcat commented Mar 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

Previews

Checklist

Uh oh!

github-actions Bot commented Mar 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

orange187 commented Mar 30, 2022

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Lanttcat commented Mar 14, 2022 •

edited

Loading

github-actions Bot commented Mar 14, 2022 •

edited

Loading