fix: watch tx confirmation event - #5945
Closed
UncleBill wants to merge 6 commits into
Closed
Conversation
UncleBill
force-pushed
the
fix/watch-confirmation
branch
from
March 24, 2022 15:54
c68ae8b to
15283f0
Compare
Contributor
Jack-Works
previously approved these changes
Mar 25, 2022
hanszhoou
previously approved these changes
Mar 25, 2022
guanbinrui
reviewed
Mar 25, 2022
UncleBill
force-pushed
the
fix/watch-confirmation
branch
from
March 25, 2022 11:53
15283f0 to
47e26b9
Compare
guanbinrui
reviewed
Mar 28, 2022
guanbinrui
reviewed
Mar 28, 2022
guanbinrui
reviewed
Mar 28, 2022
guanbinrui
reviewed
Mar 28, 2022
UncleBill
force-pushed
the
fix/watch-confirmation
branch
from
March 29, 2022 03:01
47e26b9 to
941fa34
Compare
UncleBill
commented
Mar 29, 2022
UncleBill
left a comment
UncleBill
left a comment
Contributor
Author
There was a problem hiding this comment.
@DimensionDev/qa Please help to verify.
UncleBill
force-pushed
the
fix/watch-confirmation
branch
from
March 29, 2022 03:56
941fa34 to
10f3785
Compare
guanbinrui
previously approved these changes
Mar 29, 2022
Member
|
@DimensionDev/qa |
Contributor
|
Please check comments in Jira. |
UncleBill
changed the title
guanbinrui
reviewed
Apr 6, 2022
| return new Promise<void>(async (resolve, reject) => { | ||
| method | ||
| .send(gasExpectedConfig) | ||
| .once(TransactionEventType.TRANSACTION_HASH, (hash) => { |
Member
There was a problem hiding this comment.
Why not also remove the TransactionEventType.RECEIPT event?
Member
|
Please resolve the conflicts. |
Contributor
Author
|
Succeeded by #6181 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://mask.atlassian.net/browse/MF-299