Skip to content

chore: clean bool state variable name - #5975

Merged
guanbinrui merged 1 commit into
developfrom
septs/clean-bool-state
Mar 28, 2022
Merged

chore: clean bool state variable name#5975
guanbinrui merged 1 commit into
developfrom
septs/clean-bool-state

Conversation

@septs

@septs septs commented Mar 28, 2022

Copy link
Copy Markdown
Contributor

Description

Closes # (NO_ISSUE)

Type of change

  • Documentation
  • Code refactoring (Restructuring existing code w/o changing its observable behavior)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (a fix or feature that would make something no longer possible to do/require old user must upgrade their Mask Network to this new version)

Previews

Checklist

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
    • I have removed all in development console.logs
    • I have removed all commented code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have read Internationalization Guide and moved text fields to the i18n JSON file.

If this PR depends on external APIs:

  • I have configured those APIs with CORS headers to let extension requests get passed.
    • chrome extension: chrome-extension://[id]
    • firefox extension: moz-extension://[id]
  • I have delegated all web requests to the background service via the internal RPC bridge.

@github-actions

Copy link
Copy Markdown
Contributor

@github-actions
github-actions Bot temporarily deployed to pull request March 28, 2022 12:19 Inactive
@septs
septs enabled auto-merge (squash) March 28, 2022 12:26
@guanbinrui
guanbinrui disabled auto-merge March 28, 2022 12:37
@guanbinrui
guanbinrui merged commit d4e120c into develop Mar 28, 2022
@guanbinrui
guanbinrui deleted the septs/clean-bool-state branch March 28, 2022 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants