Skip to content

fix: can't auto close dialog when lost focus - #5977

Merged
guanbinrui merged 8 commits into
developfrom
lelenei/mf-44
Apr 6, 2022
Merged

fix: can't auto close dialog when lost focus#5977
guanbinrui merged 8 commits into
developfrom
lelenei/mf-44

Conversation

@lelenei

@lelenei lelenei commented Mar 28, 2022 •
edited by guanbinrui
Loading

Copy link
Copy Markdown
Contributor

Description

Closes # mf-44

Type of change

  • Documentation
  • Code refactoring (Restructuring existing code w/o changing its observable behavior)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (a fix or feature that would make something no longer possible to do/require old user must upgrade their Mask Network to this new version)

Previews

Checklist

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
    • I have removed all in development console.logs
    • I have removed all commented code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have read Internationalization Guide and moved text fields to the i18n JSON file.

If this PR depends on external APIs:

  • I have configured those APIs with CORS headers to let extension requests get passed.
    • chrome extension: chrome-extension://[id]
    • firefox extension: moz-extension://[id]
  • I have delegated all web requests to the background service via the internal RPC bridge.

@github-actions

github-actions Bot commented Mar 28, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

🚀 Deployed on https://624d8bac715e7f17692c00db--compassionate-northcutt-326a3a.netlify.app

@github-actions
github-actions Bot temporarily deployed to pull request March 28, 2022 13:57 Inactive
@guanbinrui

guanbinrui commented Mar 29, 2022

Copy link
Copy Markdown
Member

The problem still.

@lelenei lelenei changed the title fix: auto close dialog when lost focus fix: can't auto close dialog when lost focus Mar 29, 2022
@github-actions
github-actions Bot temporarily deployed to pull request March 29, 2022 08:40 Inactive
@guanbinrui

guanbinrui commented Mar 30, 2022

Copy link
Copy Markdown
Member

@DimensionDev/qa Please check it.

@github-actions
github-actions Bot temporarily deployed to pull request March 31, 2022 13:12 Inactive
@github-actions
github-actions Bot temporarily deployed to pull request April 2, 2022 05:23 Inactive
@wenluomask

wenluomask commented Apr 2, 2022

Copy link
Copy Markdown
Contributor

Checked.

@github-actions
github-actions Bot temporarily deployed to pull request April 6, 2022 07:05 Inactive
UncleBill
UncleBill previously approved these changes Apr 6, 2022
View reviewed changes
@github-actions
github-actions Bot temporarily deployed to pull request April 6, 2022 11:37 Inactive
@github-actions
github-actions Bot temporarily deployed to pull request April 6, 2022 12:15 Inactive
@github-actions
github-actions Bot temporarily deployed to pull request April 6, 2022 12:46 Inactive
@guanbinrui
guanbinrui merged commit 648dc3d into develop Apr 6, 2022
@guanbinrui
guanbinrui deleted the lelenei/mf-44 branch April 6, 2022 14:17
lelenei added a commit that referenced this pull request Apr 6, 2022
@lelenei
fix: can't auto close dialog when lost focus (#5977)
44283f0 
* fix: auto close dialog when lost focus

* fix: reply review

* fix: reply review

* fix: reply review

* fix: tradeview position

* fix: remove icon section
@guanbinrui guanbinrui mentioned this pull request Apr 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@UncleBill UncleBill UncleBill left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Test: Tested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lelenei @guanbinrui @wenluomask @UncleBill