Skip to content

refactor: pick theme refactor from GH-6009 - #6023

Merged
Jack-Works merged 3 commits into
developfrom
pick-theme-refactor
Apr 3, 2022
Merged

refactor: pick theme refactor from GH-6009#6023
Jack-Works merged 3 commits into
developfrom
pick-theme-refactor

Conversation

@Jack-Works

Copy link
Copy Markdown
Member

Description

Closes # (NO_ISSUE)

Type of change

  • Documentation
  • Code refactoring (Restructuring existing code w/o changing its observable behavior)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (a fix or feature that would make something no longer possible to do/require old user must upgrade their Mask Network to this new version)

Previews

Checklist

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
    • I have removed all in development console.logs
    • I have removed all commented code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have read Internationalization Guide and moved text fields to the i18n JSON file.

If this PR depends on external APIs:

  • I have configured those APIs with CORS headers to let extension requests get passed.
    • chrome extension: chrome-extension://[id]
    • firefox extension: moz-extension://[id]
  • I have delegated all web requests to the background service via the internal RPC bridge.

@Jack-Works

Copy link
Copy Markdown
Member Author

This is picked from #6009, the refactor to src/utils/theme*. I split them into multiple files, with no runtime behavior changes. I'll merge it once CI passed.

@github-actions

github-actions Bot commented Apr 3, 2022

Copy link
Copy Markdown
Contributor

@github-actions
github-actions Bot temporarily deployed to pull request April 3, 2022 11:04 Inactive
@Jack-Works
Jack-Works merged commit ba6c656 into develop Apr 3, 2022
@Jack-Works
Jack-Works deleted the pick-theme-refactor branch April 3, 2022 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant