Skip to content

fix: jsx-key #6074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jack-Works merged 2 commits into from
Apr 13, 2022
Merged

fix: jsx-key #6074

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a2c5701
fix: jsx-key
septs Apr 13, 2022
510ef16
fix: human readable variable name
septs Apr 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions packages/mask/src/components/shared/ApplicationBoard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,13 +66,11 @@ export function ApplicationBoard() {
[],
)
.sort((a, b) => a.entry.defaultSortingPriority - b.entry.defaultSortingPriority)
.map((X, i) => {
return (
<Fragment key={i + X.pluginId}>
<X.entry.RenderEntryComponent disabled={!X.enabled} />
</Fragment>
)
})}
.map(({ entry, enabled }, index) => (
<Fragment key={index}>
<entry.RenderEntryComponent disabled={!enabled} />
</Fragment>
))}
</section>
</>
)
Expand Down
8 changes: 4 additions & 4 deletions packages/mask/src/extension/options-page/DashboardComponents/CollectibleList/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,14 +190,14 @@ function CollectibleListUI(props: CollectibleListUIProps) {
</Box>
) : (
<Box className={classes.root}>
{collectibles.map((x, i) => (
{collectibles.map((token, index) => (
<CollectibleItem
renderOrder={i}
token={x}
renderOrder={index}
token={token}
provider={provider}
wallet={wallet}
readonly={readonly}
key={x.tokenId + x.contractDetailed.address}
key={index}
/>
))}
</Box>
Expand Down
12 changes: 6 additions & 6 deletions packages/mask/src/extension/popups/RequestPermission/RequestPermission.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,18 +23,18 @@ export function RequestPermission(props: RequestPermissionProps) {
<DialogContent>
{origins?.length ? (
<List dense subheader={<ListSubheader>{t('popups_sites')}</ListSubheader>}>
{origins?.map((x) => (
<ListItem key={x}>
<ListItemText primary={x} />
{origins?.map((origin, key) => (
<ListItem key={key}>
<ListItemText primary={origin} />
</ListItem>
))}
</List>
) : null}
{permissions?.length ? (
<List dense subheader={<ListSubheader>{t('popups_permissions')}</ListSubheader>}>
{permissions?.map((x) => (
<ListItem key={x}>
<ListItemText primary={x} />
{permissions?.map((permission, key) => (
<ListItem key={key}>
<ListItemText primary={permission} />
</ListItem>
))}
</List>
Expand Down
4 changes: 2 additions & 2 deletions ...ges/mask/src/extension/popups/ThirdPartyRequestPermission/ThirdPartyRequestPermission.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ export function ThirdPartyRequestPermission(props: ThirdPartyRequestPermissionPr
values={{ pluginName: props.pluginName, pluginURL: props.pluginURL }}
/>
<ul>
{props.permissions.map((x) => (
<li key={x}>{ThirdPartyPluginPermission[x]}</li>
{props.permissions.map((permission, key) => (
<li key={key}>{ThirdPartyPluginPermission[permission]}</li>
))}
</ul>
<button onClick={() => window.close()}>{t('cancel')}</button>
Expand Down
40 changes: 19 additions & 21 deletions packages/mask/src/plugins/Collectible/SNSAdaptor/TokenTab.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,27 +123,25 @@ export function TokenTab(props: TokenTabProps) {
</Typography>

<Box className={classes.trait_content}>
{asset.value.traits.map(({ trait_type, value }) => {
return (
<Link
underline="none"
key={trait_type + value}
href={
asset.value?.slug
? resolveTraitLinkOnOpenSea(chainId, asset.value.slug, trait_type, value)
: ''
}
target="_blank"
rel="noopener noreferrer">
<Paper className={classes.trait} variant="outlined">
<Typography variant="body2" color="primary">
{trait_type}
</Typography>
<Typography variant="body2">{value}</Typography>
</Paper>
</Link>
)
})}
{asset.value.traits.map(({ trait_type, value }, key) => (
<Link
underline="none"
key={key}
href={
asset.value?.slug
? resolveTraitLinkOnOpenSea(chainId, asset.value.slug, trait_type, value)
: ''
}
target="_blank"
rel="noopener noreferrer">
<Paper className={classes.trait} variant="outlined">
<Typography variant="body2" color="primary">
{trait_type}
</Typography>
<Typography variant="body2">{value}</Typography>
</Paper>
</Link>
))}
</Box>
</Box>
) : null}
Expand Down