Skip to content

refactor: application board entries - #6114

Merged
hanszhoou merged 53 commits into
developfrom
hancheng/split-application-wallet-entry
May 11, 2022
Merged

refactor: application board entries#6114
hanszhoou merged 53 commits into
developfrom
hancheng/split-application-wallet-entry

Conversation

@hanszhoou

@hanszhoou hanszhoou commented Apr 20, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

image

image

Closes # (NO_ISSUE)

https://mask.atlassian.net/browse/MF-410
https://mask.atlassian.net/browse/MF-613
https://mask.atlassian.net/browse/MF-611

Type of change

  • Documentation
  • Code refactoring (Restructuring existing code w/o changing its observable behavior)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (a fix or feature that would make something no longer possible to do/require old user must upgrade their Mask Network to this new version)

Previews

Checklist

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
    • I have removed all in development console.logs
    • I have removed all commented code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have read Internationalization Guide and moved text fields to the i18n JSON file.

If this PR depends on external APIs:

  • I have configured those APIs with CORS headers to let extension requests get passed.
    • chrome extension: chrome-extension://[id]
    • firefox extension: moz-extension://[id]
  • I have delegated all web requests to the background service via the internal RPC bridge.

@github-actions

github-actions Bot commented Apr 20, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

🚀 Deployed on https://627a4c28b5a65b02c5d4e356--compassionate-northcutt-326a3a.netlify.app

@github-actions
github-actions Bot temporarily deployed to pull request April 20, 2022 11:50 Inactive
Jack-Works
Jack-Works reviewed Apr 21, 2022
View reviewed changes
Comment thread packages/mask/src/social-network/ui.ts
ui.injection.pageInspector?.(signal)
if (Flags.toolbox_enabled) ui.injection.toolbox?.(signal)
if (Flags.toolbox_enabled) {
ui.injection.toolbox?.(signal, 'wallet')

@Jack-Works Jack-Works Apr 21, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not start both in the toolbox implementation?

@hanszhoou hanszhoou Apr 22, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Toolbox implementations for SNS have already included injectToolboxHintAtMinds, injectToolboxAtFacebook and injectToolboxHintAtTwitter, and maybe more in the future. I want to keep dry.

guanbinrui
guanbinrui previously approved these changes Apr 22, 2022
View reviewed changes
UncleBill
UncleBill previously approved these changes Apr 22, 2022
View reviewed changes
@hanszhoou
hanszhoou dismissed stale reviews from UncleBill and guanbinrui via a724a45 April 22, 2022 08:27
@github-actions
github-actions Bot temporarily deployed to pull request April 22, 2022 08:32 Inactive
Jack-Works
Jack-Works previously approved these changes Apr 22, 2022
View reviewed changes
Jack-Works
Jack-Works previously approved these changes Apr 26, 2022
View reviewed changes
@github-actions
github-actions Bot temporarily deployed to pull request April 27, 2022 03:26 Inactive
guanbinrui
guanbinrui previously approved these changes Apr 27, 2022
View reviewed changes
@github-actions
github-actions Bot temporarily deployed to pull request April 27, 2022 08:35 Inactive
@github-actions
github-actions Bot temporarily deployed to pull request April 27, 2022 09:09 Inactive
guanbinrui
guanbinrui reviewed May 9, 2022
View reviewed changes
Comment thread packages/mask/src/components/shared/ApplicationBoard.tsx Outdated
guanbinrui
guanbinrui reviewed May 9, 2022
View reviewed changes
Comment thread packages/mask/src/components/shared/ApplicationBoard.tsx Outdated
guanbinrui
guanbinrui reviewed May 9, 2022
View reviewed changes
Comment thread packages/mask/src/components/shared/ApplicationBoard.tsx Outdated
@github-actions
github-actions Bot temporarily deployed to pull request May 9, 2022 04:16 Inactive
Jack-Works
Jack-Works reviewed May 9, 2022
View reviewed changes
Comment thread packages/mask/package.json
Jack-Works
Jack-Works reviewed May 9, 2022
View reviewed changes
Comment thread packages/plugins/GoPlusSecurity/src/SNSAdaptor/index.tsx
Jack-Works
Jack-Works reviewed May 9, 2022
View reviewed changes
Comment thread packages/mask/src/components/DataSource/usePersonaConnectStatus.ts Outdated
Jack-Works
Jack-Works reviewed May 9, 2022
View reviewed changes
Comment thread packages/mask/src/components/shared/ApplicationBoard.tsx Outdated
Jack-Works
Jack-Works reviewed May 9, 2022
View reviewed changes
Comment thread packages/mask/src/components/shared/ApplicationBoard.tsx Outdated
@github-actions
github-actions Bot temporarily deployed to pull request May 9, 2022 07:07 Inactive
@hanszhoou
hanszhoou requested review from Jack-Works and guanbinrui May 9, 2022 07:18
Jack-Works
Jack-Works previously requested changes May 10, 2022
View reviewed changes

@Jack-Works Jack-Works left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

request changes

Comment thread packages/shared/src/contexts/components/InjectedDialog.tsx Outdated
Comment thread packages/plugins/CrossChainBridge/src/SNSAdaptor/index.tsx Outdated
Comment thread packages/mask/src/components/shared/ApplicationRecommendArea.tsx Outdated
Comment thread packages/mask/src/components/shared/ApplicationRecommendArea.tsx Outdated
Comment thread packages/mask/src/components/DataSource/usePersonaAgainstSNSConnectStatus.ts Outdated
Comment thread packages/mask/src/components/DataSource/usePersonaAgainstSNSConnectStatus.ts Outdated
@Jack-Works Jack-Works mentioned this pull request May 10, 2022
Merged
13 tasks
@hanszhoou
hanszhoou requested a review from Jack-Works May 10, 2022 05:52
@github-actions
github-actions Bot temporarily deployed to pull request May 10, 2022 06:01 Inactive
@hanszhoou
hanszhoou requested a review from Jack-Works May 10, 2022 11:23
@github-actions
github-actions Bot temporarily deployed to pull request May 10, 2022 11:27 Inactive
@hanszhoou
hanszhoou merged commit b98de49 into develop May 11, 2022
@hanszhoou
hanszhoou deleted the hancheng/split-application-wallet-entry branch May 11, 2022 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BillySh1 BillySh1 BillySh1 approved these changes
@UncleBill UncleBill Awaiting requested review from UncleBill
@guanbinrui guanbinrui Awaiting requested review from guanbinrui
@Jack-Works Jack-Works Awaiting requested review from Jack-Works
+1 more reviewer
@lelenei lelenei lelenei approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Test: Tested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@hanszhoou @UncleBill @Jack-Works @guanbinrui @BillySh1 @lelenei @wenluomask