-
Notifications
You must be signed in to change notification settings - Fork 316
feat: setup improve for testing #6187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
00f65f9
feat: split wallet app entries
hanszhoou 4957651
chore: type
hanszhoou 9653259
chore: type
hanszhoou a724a45
Merge branch 'develop' into hancheng/split-application-wallet-entry
hanszhoou 993a4e1
feat: user guide
yanzhihong23 a6a0438
chore: solve conflict
hanszhoou 3f84e7e
Revert "chore: solve conflict"
hanszhoou 68358ed
Merge branch 'develop' into hancheng/split-application-wallet-entry
hanszhoou d6f5ed4
chore: solve conflict
hanszhoou 5bf451e
feat: should open twitter when user click agree button on welcome page
Lanttcat 912ea48
feat: be opened social network should determined by the caller
Lanttcat 0366282
feat: merge develop
Lanttcat c66d357
feat: recommend feature app
hanszhoou dd64f52
chore: update event
hanszhoou 1dfe7e9
Merge branch 'develop' into hancheng/split-application-wallet-entry
hanszhoou dc84ea1
chore: persona connect
hanszhoou 086d846
fix: little fix
hanszhoou b2d96dd
Merge branch 'develop' into hancheng/split-application-wallet-entry
hanszhoou df51ff4
fix: dialog title text center
hanszhoou 6dd82ca
fix: style
hanszhoou 7fd0bdd
chore: add comment
hanszhoou caea3be
fix: ui style
hanszhoou 321f852
chore: ui style
hanszhoou e69ad12
Merge branch 'hancheng/split-application-wallet-entry' into feat-user…
yanzhihong23 1d7751d
Merge branch 'feat-user-guide' into feat/setup-improve-for-testing
Lanttcat 70533a9
Merge branch 'feat/dashboard-setup-optimize' into feat/setup-improve-…
Lanttcat e79aeb7
fix: can't open composition dialog when there is no persona
yanzhihong23 f463f61
fix: user guide step 3 not showing
yanzhihong23 bc7196e
fix: zh translation
yanzhihong23 6c1548e
Merge branch 'develop' into feat/setup-improve-for-testing
hanszhoou 3f065ef
fix: identity collecting
yanzhihong23 019c658
fix: typo
yanzhihong23 33d87fe
Merge branch 'develop' into feat/setup-improve-for-testing
hanszhoou b9e02ad
feat: setup social network in current window
yanzhihong23 1da164b
chore: remove useSetupSocialNetwork hook
yanzhihong23 4e70de3
chore: reply review
yanzhihong23 8f4c1aa
feat: disable open composition dialog after user guide
yanzhihong23 26bb154
Revert "feat: disable open composition dialog after user guide"
yanzhihong23 bd1a0a5
feat: code review feedback
Lanttcat 6b32288
refactor: remove unnecessary array deconstruction
Lanttcat e4a2fdd
refactor: use location assign to replace direction assignment
Lanttcat File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -90,7 +90,6 @@ export async function activateSocialNetworkUIInner(ui_deferred: SocialNetworkUI. | |
| ui.injection.toolbox?.(signal, 'wallet') | ||
| ui.injection.toolbox?.(signal, 'application') | ||
| } | ||
| ui.injection.setupPrompt?.(signal) | ||
| ui.injection.newPostComposition?.start?.(signal) | ||
| ui.injection.searchResult?.(signal) | ||
| ui.injection.userBadge?.(signal) | ||
|
|
@@ -229,6 +228,19 @@ export async function activateSocialNetworkUIInner(ui_deferred: SocialNetworkUI. | |
| } | ||
| } | ||
|
|
||
| export async function loadSocialNetworkUIs(): Promise<SocialNetworkUI.Definition[]> { | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why you're going to load every SNS Adaptors?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We need to have the user authorize all SNS before creating persona. |
||
| const defines = [...definedSocialNetworkUIs.values()].map(async (x) => x.load()) | ||
| const uis = (await Promise.all(defines)).map((x) => x.default) | ||
|
|
||
| if (!defines) throw new Error('SNS adaptor load failed') | ||
|
|
||
| for (const ui of uis) { | ||
| definedSocialNetworkUIsResolved.set(ui.networkIdentifier, ui) | ||
| } | ||
|
|
||
| return uis | ||
| } | ||
|
|
||
| export async function loadSocialNetworkUI(identifier: string): Promise<SocialNetworkUI.Definition> { | ||
| if (definedSocialNetworkUIsResolved.has(identifier)) return definedSocialNetworkUIsResolved.get(identifier)! | ||
| const define = definedSocialNetworkUIs.get(identifier) | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you set up Twitter by default?