Skip to content

fix: personaActionButton display error - #6361

Merged
guanbinrui merged 1 commit into
developfrom
fix/persona-button-display
May 26, 2022
Merged

fix: personaActionButton display error#6361
guanbinrui merged 1 commit into
developfrom
fix/persona-button-display

Conversation

@Randolph314

@Randolph314 Randolph314 commented May 26, 2022

Copy link
Copy Markdown
Contributor

Description

Closes #855

Type of change

  • Documentation
  • Code refactoring (Restructuring existing code w/o changing its observable behavior)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (a fix or feature that would make something no longer possible to do/require old user must upgrade their Mask Network to this new version)

Previews

Checklist

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
    • I have removed all in development console.logs
    • I have removed all commented code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have read Internationalization Guide and moved text fields to the i18n JSON file.

If this PR depends on external APIs:

  • I have configured those APIs with CORS headers to let extension requests get passed.
    • chrome extension: chrome-extension://[id]
    • firefox extension: moz-extension://[id]
  • I have delegated all web requests to the background service via the internal RPC bridge.

@Randolph314
Randolph314 requested review from Jack-Works and Lanttcat and removed request for Jack-Works May 26, 2022 08:33
@github-actions

Copy link
Copy Markdown
Contributor

@github-actions
github-actions Bot temporarily deployed to pull request May 26, 2022 08:37 Inactive
@AinuX

AinuX commented May 26, 2022

Copy link
Copy Markdown
Collaborator

Checked

@guanbinrui
guanbinrui merged commit f804a91 into develop May 26, 2022
@guanbinrui
guanbinrui deleted the fix/persona-button-display branch May 26, 2022 09:14
Randolph314 added a commit that referenced this pull request May 26, 2022
Co-authored-by: Randolph <840094513@qq.com>
@Randolph314
Randolph314 restored the fix/persona-button-display branch June 1, 2022 06:16
@Lanttcat Lanttcat mentioned this pull request Jun 2, 2022
13 tasks
@Jack-Works
Jack-Works deleted the fix/persona-button-display branch September 11, 2022 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants