refactor: pending requests on popup page - #6381
Merged
Merged
Conversation
guanbinrui
force-pushed
the
refactor/pending-request-popup
branch
from
May 30, 2022 08:04
90d6ba4 to
138a392
Compare
Contributor
guanbinrui
force-pushed
the
refactor/pending-request-popup
branch
from
May 30, 2022 08:34
138a392 to
43f43eb
Compare
guanbinrui
force-pushed
the
refactor/pending-request-popup
branch
from
May 30, 2022 10:14
43f43eb to
a56450c
Compare
guanbinrui
force-pushed
the
refactor/pending-request-popup
branch
from
May 30, 2022 11:14
a56450c to
650defc
Compare
guanbinrui
force-pushed
the
refactor/pending-request-popup
branch
from
May 30, 2022 14:38
650defc to
90940ef
Compare
guanbinrui
marked this pull request as ready for review
May 30, 2022 14:39
guanbinrui
force-pushed
the
refactor/pending-request-popup
branch
from
May 30, 2022 14:39
90940ef to
2afdc80
Compare
UncleBill
previously approved these changes
May 30, 2022
nuanyang233
reviewed
May 30, 2022
Lanttcat
approved these changes
May 31, 2022
nuanyang233
approved these changes
May 31, 2022
Jack-Works
reviewed
May 31, 2022
| return string | ||
| }, | ||
| createScriptURL: (string) => string, | ||
| createScript: (string) => string, |
Member
There was a problem hiding this comment.
@nuanyang233 do not add createScript! This allows eval
This was referenced Sep 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes # (NO_ISSUE)
Type of change