Skip to content

fix: duplicated twitter decrypt post content #6798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guanbinrui merged 1 commit into from
Jul 14, 2022
Merged

fix: duplicated twitter decrypt post content #6798

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions packages/mask/src/social-network-adaptor/twitter.com/utils/selector.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,23 +195,6 @@ export const postsContentSelector = () =>
// reply-tweets
'[data-testid="tweet"] + div div div[lang][dir]',
].join(),
).concat(
querySelectorAll('[data-testid="tweet"] > div:last-child').map((x) => {

@Jack-Works Jack-Works Jul 14, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks like a feature. do you sure you're going to remove the whole section?

const textElement = x.querySelector('[role="group"]')?.parentElement?.querySelector('div[lang]') as
| HTMLDivElement
| undefined

if (textElement) return textElement

// There's no textElement as there's only a twitter summary card parsed by a single url.
const summaryCardElement = x
.querySelector('[role="group"]')
?.parentElement?.querySelector('[data-testid="card.wrapper"]')?.previousElementSibling as
| HTMLDivElement
| undefined

return summaryCardElement
}), // timeline page for new twitter
)

export const postAvatarsContentSelector = () =>
Expand Down