Bump usvg to 0.48.1 - #78
Draft
nicoburns wants to merge 2 commits into
Draft
Conversation
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
The children of usvg's flattened text group already carry the text node's absolute transform, so recursing with the accumulated transform applied it twice, misplacing and mis-scaling all SVG text.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bump the workspace
usvgdependency from 0.46.0 to 0.48.1. No code changes required;anyrender_svgcompiles as-is (all-features checked).Motivation: usvg 0.48 fixes missing-dimension computation from the viewBox aspect ratio (resvg#1045), and a pending upstream addition (
Tree::intrinsic_dimensions, linebender/resvg branchDioxusLabs:devin/1785858271-intrinsic-dimensions) lets Blitz implement CSS intrinsic sizing for SVG replaced elements without re-parsing the XML. Sinceusvg::Treecrosses the blitz-dom → anyrender_svg boundary, Blitz can only upgrade once anyrender_svg does.MSRV: usvg 0.48.1 requires 1.85; workspace rust-version is 1.88, so unaffected.
Link to Devin session: https://app.devin.ai/sessions/1372da3cbba94b90a9c63cad94bdbdc1
Requested by: @nicoburns