anyrender_svg: don't apply text transform twice - #79
Closed
nicoburns wants to merge 1 commit into
Closed
Conversation
The children of usvg's flattened text group already carry the text node's absolute transform, so recursing with the accumulated transform applied it twice, misplacing and mis-scaling all SVG text.
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
Superseded by DioxusLabs/resvg#2, which reverts the usvg 0.48 behaviour change instead — with that revert, the existing anyrender_svg code is correct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SVG
<text>was rendered with its transform applied twice, so text on e.g. shields.io badges (https://img.shields.io/crates/v/blitz.svg, which wraps text in<g transform="scale(.1)">withfont-size="110") ended up 100× too small and mispositioned (effectively invisible).In
render_group, each child'sabs_transform()is pre-multiplied intotransformbefore dispatch. The children ofusvg::Text::flattened()already carry the text node's absolute transform, so theNode::Textbranch must recurse withAffine::IDENTITY(as theNode::Groupbranch does), not with the accumulatedtransform:usvg::Node::Text(text) => { - render_group(scene, text.flattened(), transform, global_transform, error_handler); + render_group(scene, text.flattened(), Affine::IDENTITY, global_transform, error_handler); }Verified via Blitz's screenshot example: badge text now renders identically to resvg's reference output.
Before / after (rendered by Blitz):
Link to Devin session: https://dioxus.staging.devinenterprise.com/sessions/e3ee5d93814646ef9f657861d05792d9
Requested by: @nicoburns