ENG-1373: Drag pages onto the canvas to create node shapes by sid597 · Pull Request #1083 · DiscourseGraphs/discourse-graph

sid597 · 2026-05-25T09:04:39Z

eng-1373.mp4

Page refs aren't draggable by default, so make them draggable via the existing rm-page-ref observer and route the drag payload through the canvas text-content handler that already turns [[name]] into a discourse-node shape. - Always-on: only the draggable attribute is global; the drag payload and drop handling live in the canvas component, so drags are inert unless a canvas is open. - Custom MIME (application/x-roam-page), not text/plain, so a drag can't leak [[title]] into other blocks or apps. - Guard the existing block-dragstart so dragging a ref doesn't also attach its containing block's UID.

linear-code · 2026-05-25T09:04:42Z

ENG-1373

supabase · 2026-05-25T09:04:51Z

This pull request has been ignored for the connected project zytfjzqyijgagqxrzbmz because there are no changes detected in packages/database/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 014d57e942

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

The always-on registration had no matching teardown, so the singleton rm-page-ref observer and the makePageRefDraggable callback survived extension unload/reload. Add a cleanup that unregisters the handler; for users without the overlay/preview/suggestive handlers this empties the set and disconnects the observer.

The first commit only captured spans whose data-link-title lives on the parent element. Query-builder result rows and the discourse-context overlay render page links as <a class="rm-page-ref" data-link-title="..."> with the title on the element itself, which the existing parent-only read missed. Also resolve a dragged block whose text is exactly [[X]] to that discourse node's shape (instead of a gray blck-node) when X is a discourse node. The page-ref branch already does this, so factor out tryCreatePageNodeShape and reuse it from the block-ref path; the heavy page-uid + discourse-node lookup is gated behind a cheap PAGE_REF_REGEX match on the block text. - Read data-link-title on the page-ref element itself, falling back to the parent for span page-refs. - Extract tryCreatePageNodeShape; the boolean return lets callers decide the fallback (default text handler vs. blck-node). - Hoist PAGE_REF_REGEX to module scope next to BLOCK_REF_REGEX usage.

mdroidian · 2026-05-30T00:48:06Z

@codex review

chatgpt-codex-connector · 2026-05-30T00:50:28Z

Codex Review: Didn't find any major issues. Keep them coming!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

mdroidian

https://www.loom.com/share/b7fa55afb36a48bd8fabe14391f8fe65

I think this needs one more pass before merging.

The goal is to drag a page reference from inside an outliner block onto the canvas. Right now, mixed-content blocks still open the page instead of allowing drag.

It also looks like this changes the behavior when a page reference is the only content in a block: dragging the block now creates a page node instead of a block node. I’m not sure we want to change that existing block-drag behavior.

Expected behavior: dragging the specific page reference should add that page to the canvas, similar to the discourse context behavior, without changing how the containing block itself drags.

Could you also test/show:

link/render/embed query views
multiple canvases, including sidebar canvases, to check useEffect behavior

vercel · 2026-06-16T17:17:33Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
discourse-graph	Skipped		Jul 22, 2026 3:48pm

mattakamatsu · 2026-07-12T07:10:42Z

Ping! I wanted to use this feature recently, would love to put it back on @sid597's backlog, thankx

Query link and alias views render page refs as a.rm-page-ref anchors, which the shared SPAN-only page-ref observer never sees, so those results offered no drag handle. The drag-source system now observes anchors with its own createHTMLObserver and runs them through the same listener wiring (observePageRef generalized to HTMLElement); observed locally so anchors are not fed to the shared observer's other handlers (overlays, previews). Verified by the eng-1373-query-views storyboard: its link-view drag scene failed before this change and passes after. The query-page crash seen on the dev graph while testing (matchDiscourseNode on relations pointing at deleted node types) is pre-existing on main and will be fixed separately.

…fallback

mdroidian

Just listing some discussion points from Friday

Use absolute positioning for the drag handle so it overlays the text instead of causing text reflow on hover.
Change the drag handle icon color from red to gray so it matches the existing icon palette.
Fix the post-drag bug where the handle disappears from other blocks until the next click, likely due to the observer not re-firing.

… Roam drop overlays after canvas drops

…nt text

sid597 · 2026-07-19T17:42:29Z

@mdroidian Fixed all 3 points and updated the video to use latest code

mdroidian · 2026-07-19T20:31:32Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 516d39eccb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-07-19T20:33:57Z

+  const pageRefAnchorObserver = createHTMLObserver({
+    useBody: true,
+    tag: "A",
+    className: "rm-page-ref",
+    callback: observePageRef,
+  });


Attach drag listeners to existing page-link anchors

When a query link/alias view has already rendered before this canvas effect runs, its a.rm-page-ref elements are never passed to observePageRef: createHTMLObserver only covers subsequently added nodes, while the shared span path explicitly applies its handler to existing refs via onPageRefObserverChange. Consequently, opening or mounting a canvas alongside an already-rendered query leaves those page links without a drag handle until the query rerenders. Query the existing a.rm-page-ref elements here as well before relying on the observer.

Useful? React with 👍 / 👎.

mdroidian · 2026-07-19T20:34:31Z

@mdroidian Fixed all 3 points and updated the video to use latest code

Hey @sid597 , there is no mouse in the video so it's really hard to see that all three issues are solved. I think I made out the second (absolute positioning) but it only displays for a very brief moment.

Did you test the post-drag bug fix yourself?

mdroidian · 2026-07-20T00:49:23Z

@sid597 have you tried dragging an [[EVD]] or [[RES]]? How do you handle the multiple referenced pages?

mdroidian

https://www.loom.com/share/4c2add16b45b49b1b2f3e464f56b8394

Change requests:

Match the background of the icon to the background of the window (white if main window, gray if sidebar)
Move the handle farther right so it sits outside the page reference’s closing ]] brackets instead of overlapping them.
Stabilize handle placement for multiline references.
Do not render drag handles for nested references inside another reference, such as “EVD” or “Source” references embedded within a larger “Evidence” reference.
Change the mouse pointer to grabbing when over the drag icon

A few more issues found
https://www.loom.com/share/00f51beb434349b99d4b1a8dcf661c0d

change: remove drag handles from titles
bug: drag handle moves and is persistent when mouse is removed from the left

After making these changes, please ensure the video records a comprehensive manual regression pass. Eg: demonstrating the drag behavior in the main window, sidebar, Kanban, and query link, embed, and render views. Include single-line, multiline, wrapping, and nested references in each applicable surface.

chatgpt-codex-connector Bot reviewed May 25, 2026

View reviewed changes

Comment thread apps/roam/src/utils/initializeObserversAndListeners.ts Outdated

sid597 added 3 commits May 25, 2026 15:08

Scope page ref canvas dragging

cbee62a

graphite-app Bot reviewed May 28, 2026

View reviewed changes

Comment thread apps/roam/src/components/canvas/Tldraw.tsx Outdated

Format canvas drag changes

4cef969

graphite-app Bot reviewed May 28, 2026

View reviewed changes

Comment thread apps/roam/src/components/canvas/Tldraw.tsx Outdated

Fix canvas block drag fallback

459fba1

sid597 requested a review from mdroidian May 29, 2026 05:53

mdroidian requested changes Jun 8, 2026

View reviewed changes

Comment thread apps/roam/src/components/canvas/Tldraw.tsx Outdated

Comment thread apps/roam/src/components/canvas/Tldraw.tsx

Comment thread apps/roam/src/components/canvas/Tldraw.tsx Outdated

Enable page reference drags to canvas

472b588

vercel Bot temporarily deployed to Preview June 16, 2026 17:17 Inactive

Clarify canvas text content analytics

467b925

vercel Bot temporarily deployed to Preview June 16, 2026 17:48 Inactive

Handle page link drags without navigation

2cdac41

vercel Bot temporarily deployed to Preview June 17, 2026 04:35 Inactive

Mark hovered page refs draggable on pointerover

66900fe

vercel Bot temporarily deployed to Preview July 6, 2026 10:34 Inactive

Improve page reference drag performance

41f04c5

vercel Bot temporarily deployed to Preview July 13, 2026 15:27 Inactive

vercel Bot temporarily deployed to Preview July 17, 2026 07:16 Inactive

Address pre-PR review: keep existing analytics event name, drop dead …

4904964

…fallback

vercel Bot temporarily deployed to Preview July 17, 2026 09:43 Inactive

sid597 requested a review from mdroidian July 17, 2026 10:14

mdroidian requested changes Jul 18, 2026

View reviewed changes

Address review: overlay drag handle without reflow, gray icon, disarm…

e092076

… Roam drop overlays after canvas drops

vercel Bot temporarily deployed to Preview July 19, 2026 03:34 Inactive

Give drag handle an opaque background so it reads cleanly over adjace…

516d39e

…nt text

vercel Bot temporarily deployed to Preview July 19, 2026 04:00 Inactive

graphite-app Bot reviewed Jul 19, 2026

View reviewed changes

Comment thread apps/roam/src/components/canvas/Tldraw.tsx

sid597 requested a review from mdroidian July 19, 2026 17:41

chatgpt-codex-connector Bot reviewed Jul 19, 2026

View reviewed changes

mdroidian requested changes Jul 20, 2026

View reviewed changes

Fix page reference drag handle targeting

da6a281

vercel Bot temporarily deployed to Preview July 22, 2026 10:24 Inactive

Fix multiline page reference drag handles

6a93a27

vercel Bot temporarily deployed to Preview July 22, 2026 15:39 Inactive

Position drag handles from final text line

ce5c87c

vercel Bot temporarily deployed to Preview July 22, 2026 15:48 Inactive

Uh oh!

Conversation

sid597 commented May 25, 2026 • edited by mdroidian Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

linear-code Bot commented May 25, 2026

Uh oh!

supabase Bot commented May 25, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mdroidian commented May 30, 2026

Uh oh!

chatgpt-codex-connector Bot commented May 30, 2026

Uh oh!

mdroidian left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vercel Bot commented Jun 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mattakamatsu commented Jul 12, 2026

Uh oh!

mdroidian left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sid597 commented Jul 19, 2026

Uh oh!

mdroidian commented Jul 19, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jul 19, 2026

Choose a reason for hiding this comment

Uh oh!

mdroidian commented Jul 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mdroidian commented Jul 20, 2026

Uh oh!

mdroidian left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sid597 commented May 25, 2026 •

edited by mdroidian

Loading

vercel Bot commented Jun 16, 2026 •

edited

Loading

mdroidian commented Jul 19, 2026 •

edited

Loading