fix(converter): allow Greedy[...] to accept union types #1482
+11
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #1421 =>
commands.Greedy[...]to correctly support Python 3.10+ union types (PEP 604 A | B) and typing.Union.Previously, passing a union type like
commands.Greedy[disnake.Member | disnake.Object]would raise:This PR updates
Greedy.__class_getitem__to:typing.get_originandtyping.get_argsGreedy[str]andGreedy[None];Greedy[Optional[T]];Greedy[Greedy[T]]getattr(converter, "__name__", repr(converter))for safe error messagesNow,
Greedy[disnake.Member | disnake.Object]works as expected, allowing commands to greedily consume multiple valid converter types.Checklist
uv run nox -s lintuv run nox -s pyright