Skip to content

Fixes issue where modal heading could overlap button.#286

Merged
DFurnes merged 3 commits intodevfrom
modal-button-overlap
May 20, 2014
Merged

Fixes issue where modal heading could overlap button.#286
DFurnes merged 3 commits intodevfrom
modal-button-overlap

Conversation

@DFurnes
Copy link
Contributor

@DFurnes DFurnes commented May 20, 2014

screen shot 2014-05-20 at 9 46 30 am

Fixes DoSomethingArchive/legacy-website#2217.
For review: @DoSomething/front-end

@weerd
Copy link
Contributor

weerd commented May 20, 2014

Would be cool to also fix up the line-height on mobile. It's sooooo roomy! lol

@barryclark
Copy link
Contributor

This is too much copy for the header part of the modal, the "make sure to full everything out." part should be removed.

@mikefantini @aaronschachter Is there any type of character limit in header for the address collection modal?

@mikefantini
Copy link

oh crap I don't think Aaron B understood what I meant... I'll talk to him that should just be "Want Free Thumb Socks"

@mikefantini
Copy link

@DFurnes the part I was talking about re: overlapping was field headers like "Who are you sharing Thumb Socks With and Why" (in addition to the user feedback i.e. The Fantini-inator. People call you that right? gets cut off on mobile)

@DFurnes
Copy link
Contributor Author

DFurnes commented May 20, 2014

@mikefantini Yep, working on that in DoSomethingArchive/legacy-website#2167.

@mikefantini
Copy link

cool... ok well I just changed the header copy for that modal

@DFurnes
Copy link
Contributor Author

DFurnes commented May 20, 2014

Campaigns page:
screen shot 2014-05-20 at 12 56 04 pm

Modals:

screen shot 2014-05-20 at 12 56 19 pm

screen shot 2014-05-20 at 12 55 56 pm

screen shot 2014-05-20 at 12 55 45 pm

DFurnes added a commit that referenced this pull request May 20, 2014
Fixes issue where modal heading could overlap button.
@DFurnes DFurnes merged commit d3ff6d9 into dev May 20, 2014
@DFurnes DFurnes deleted the modal-button-overlap branch May 20, 2014 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Headings in banners can overlap "x" or "skip" button

4 participants