Skip to content
This repository was archived by the owner on Oct 29, 2020. It is now read-only.

Static content misc#1549

Merged
weerd merged 2 commits intoDoSomethingArchive:devfrom
weerd:static-content--misc
Mar 27, 2014
Merged

Static content misc#1549
weerd merged 2 commits intoDoSomethingArchive:devfrom
weerd:static-content--misc

Conversation

@weerd
Copy link
Copy Markdown
Contributor

@weerd weerd commented Mar 27, 2014

Need to double-check the confirmation and explore-campaigns pages since I'm not sure how to best view them on local. The explore-campaigns page seems to be generated by Views, but I don't see the template being used in Paraneue_DS.

Resolves #1515 (most of it anyhoo).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Semantically, this makes sense but it brings the front-end terminology out of sync with the field/variable names.

Should we update this in the module as well?

@weerd
Copy link
Copy Markdown
Contributor Author

weerd commented Mar 27, 2014

We could update the module as well (at least the variable), but updating the fields in the DB might get hairy...

@aaronschachter
Copy link
Copy Markdown
Contributor

agree, easy enough to just change the preprocess vars to match.

@weerd
Copy link
Copy Markdown
Contributor Author

weerd commented Mar 27, 2014

Cool. I can add another issue for me to update the preprocess vars in the .module :)

@DFurnes
Copy link
Copy Markdown
Contributor

DFurnes commented Mar 27, 2014

🎯

weerd added a commit that referenced this pull request Mar 27, 2014
@weerd weerd merged commit 564d52d into DoSomethingArchive:dev Mar 27, 2014
@weerd weerd deleted the static-content--misc branch March 27, 2014 20:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

static content - link / button and misc styling

4 participants