Skip to content
This repository was archived by the owner on Oct 29, 2020. It is now read-only.

Fixes issue with social icons on mobile dropping below subfooter.#3756

Merged
DFurnes merged 1 commit intoDoSomethingArchive:devfrom
DFurnes:footer-fix
Jan 20, 2015
Merged

Fixes issue with social icons on mobile dropping below subfooter.#3756
DFurnes merged 1 commit intoDoSomethingArchive:devfrom
DFurnes:footer-fix

Conversation

@DFurnes
Copy link
Contributor

@DFurnes DFurnes commented Jan 20, 2015

Changes

  • Fixes issue where social links were dropping below the privacy policy and ToS links. (Was missing necessary div for the table-footer trickiness to work.)

For review: @DoSomething/front-end

Was missing necessary div for the table-footer trickiness to work.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could this just be a .wrapper class and then the .footer__column sits inside that instead of plural/singular thing?

@DFurnes
Copy link
Contributor Author

DFurnes commented Jan 20, 2015

Merging pending further discussion. 🎨

DFurnes added a commit that referenced this pull request Jan 20, 2015
Fixes issue with social icons on mobile dropping below subfooter.
@DFurnes DFurnes merged commit 0be496f into DoSomethingArchive:dev Jan 20, 2015
@DFurnes DFurnes deleted the footer-fix branch January 20, 2015 18:38
@weerd
Copy link
Contributor

weerd commented Jan 20, 2015

LOL 🐪

@DFurnes
Copy link
Contributor Author

DFurnes commented Jan 20, 2015

👹

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants