Skip to content
This repository was archived by the owner on Oct 29, 2020. It is now read-only.

Proposed solution for #4244.#4245

Merged
sergiitk merged 1 commit intoDoSomethingArchive:devfrom
sergiitk:fixes-php-warnings
Mar 19, 2015
Merged

Proposed solution for #4244.#4245
sergiitk merged 1 commit intoDoSomethingArchive:devfrom
sergiitk:fixes-php-warnings

Conversation

@sergiitk
Copy link
Contributor

@sergiitk
Copy link
Contributor Author

@DFurnes, as I understand page_bottom region should be responsible for modal dialogs, see paraneue_dosomething_page_alter_login() and paraneue_dosomething_page_alter_register(). Please ensure this works right.

@DFurnes
Copy link
Contributor

DFurnes commented Mar 19, 2015

Yep, that's correct. Have you tested that modals are still properly added to the page with this change?

@sergiitk
Copy link
Contributor Author

Yes. Errors disappeared and the modals still work.

@DFurnes
Copy link
Contributor

DFurnes commented Mar 19, 2015

Cool, let's ship it then! :shipit:

sergiitk added a commit that referenced this pull request Mar 19, 2015
@sergiitk sergiitk merged commit 35d230b into DoSomethingArchive:dev Mar 19, 2015
@sergiitk sergiitk deleted the fixes-php-warnings branch March 19, 2015 15:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

PHP 5.5 Illegal string offset warnings

2 participants