This repository was archived by the owner on Oct 29, 2020. It is now read-only.
Allowing chrome nav items to be translateable.#5463
Merged
weerd merged 1 commit intoDoSomethingArchive:devfrom Oct 13, 2015
weerd:translating-chrome-naviagtion-items
Merged
Allowing chrome nav items to be translateable.#5463weerd merged 1 commit intoDoSomethingArchive:devfrom weerd:translating-chrome-naviagtion-items
weerd merged 1 commit intoDoSomethingArchive:devfrom
weerd:translating-chrome-naviagtion-items
Conversation
Contributor
Author
|
@DFurnes gave a verbal 👍 |
weerd
added a commit
that referenced
this pull request
Oct 13, 2015
Allowing chrome nav items to be translateable.
Contributor
|
Fabulous PR! 📄 ✏️ 😉 |
Contributor
Author
|
Thanks FUUUUUURNS! @DFurnes ^ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5460
What's this PR do?
This PR enables the chrome navigation items to be translateable via the use of the
t()function.Where should the reviewer start?
Only one file updated so I guess start on that one? Huzzah! preprocess.inc
How should this be manually tested?
Meh. Kinda of a pain in the butt. Easier to test on staging once deployed. Just make sure I closed all my parentheses!
What are the relevant tickets?
#5460
@DFurnes @angaither