This repository was archived by the owner on Oct 29, 2020. It is now read-only.
Allow admins to un-publish nodes without runs.#6082
Merged
sbsmith86 merged 1 commit intoDoSomethingArchive:devfrom Jan 25, 2016
Merged
Allow admins to un-publish nodes without runs.#6082sbsmith86 merged 1 commit intoDoSomethingArchive:devfrom
sbsmith86 merged 1 commit intoDoSomethingArchive:devfrom
Conversation
Contributor
|
👍 |
sbsmith86
added a commit
that referenced
this pull request
Jan 25, 2016
Allow admins to un-publish nodes without runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's this PR do?
Before disabling the publish check box on nodes, checks to see if the box not checked. If the box is checked, then we allow the user to unpublish the node. Otherwise, if the box is not checked, and a run is not selected, we disable the box so they can't publish without a run.
Any background context you want to provide?
We used JS to disable the publish check box on campaign nodes that didn't have a run selected to ensure the relationship between campaigns and campaign runs. But we needed to allow already published campaigns that didn't have a run tied to them to be unpublished.
What are the relevant tickets?
Fixes #6073