This repository was archived by the owner on Oct 29, 2020. It is now read-only.
Fix syncing @email users.#6495
Merged
DFurnes merged 1 commit intoDoSomethingArchive:devfrom May 25, 2016
DFurnes:at-email-sync
Merged
Fix syncing @email users.#6495DFurnes merged 1 commit intoDoSomethingArchive:devfrom DFurnes:at-email-sync
@email users.#6495DFurnes merged 1 commit intoDoSomethingArchive:devfrom
DFurnes:at-email-sync
Conversation
Also unsets email for synced users. We were previously only removing this field on manual migration, not when syncing users on demand.
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's this PR do?
This pull request fixes syncing
@mobileusers, which previously only got transformed when manually migrating users. It also extracts shared code between those two into a shared "transformation" function that then gets called for each unique use case, since there was like a ton of duplication.How should this be reviewed?
Make sure I didn't miss anything when extracting shared logic into the new
dosomething_northstar_transform_userfunction, and that each of the original functions still add their special sauce.Any background context you want to provide?
🎎
Relevant tickets
Fixes #6480.
Checklist